996291 - Calendar mozL10n API use cleanups

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Calendar, defect)

Description

[Zibi Braniecki [:zbraniecki][:gandalf]]

Calendar uses manual code to emulate what we want to achieve with mozL10n.once: https://github.com/mozilla-b2g/gaia/blob/b7a304a173a0b7e0fdd201efb788b20c5bea0267/apps/calendar/js/app.js#L411-L421

After landing bug 993189 we should switch.

Comment 1

[Evan Tseng [:evanxd]]

Sure.

Comment 2

[Zibi Braniecki [:zbraniecki][:gandalf]]

mozL10n.once has landed. Feel free to switch.

Comment 3

[Zibi Braniecki [:zbraniecki][:gandalf]]

Attachment: pull request

Comment 4

[Staś Małolepszy :stas]

Should observeDateLocalization in apps/calendar/js/app.js also use mozL10n.ready?

Comment 5

[Zibi Braniecki [:zbraniecki][:gandalf]]

(In reply to Staś Małolepszy :stas from comment #4)
> Should observeDateLocalization in apps/calendar/js/app.js also use
> mozL10n.ready?

I don't think so. This is used to manage re-translations, not the initial translation. (observeDateLocalization is called by _init which is after this patch called by mozL10n.once).

What's interesting is that without this patch there's a bug.

https://github.com/mozilla-b2g/gaia/blob/master/apps/calendar/js/app.js#L418-L420 - next() is called on each re-translation, but because it tests var `pending` for being false, it will fire _init only once, but it'll preserve the closure forever.

Comment 6

[Zibi Braniecki [:zbraniecki][:gandalf]]

Comment on attachment 8409819 [details] [review]
pull request

Kevin, can you look at this patch?

Comment 7

[Gareth Aye [:gaye] (back from PTO)]

lgtm fwiw :P

Comment 8

[Kevin Grandon :kgrandon]

Comment on attachment 8409819 [details] [review]
pull request

(In reply to Gareth Aye [:gaye] from comment #7)
> lgtm fwiw :P

Feel free to steal calendar reviews from me if you want :)

Seems easy enough, and happy travis means I am happy. Thanks for the patch!

Comment 9

[Zibi Braniecki [:zbraniecki][:gandalf]]

I named the function and rebased it on top of the latest master. I'll wait for travis and merge.

Comment 10

[Zibi Braniecki [:zbraniecki][:gandalf]]

aand one test failed. I'll debug it tomorrow.

Comment 11

[Zibi Braniecki [:zbraniecki][:gandalf]]

aand, it was noise, cannot reproduce and it passes now. merging.

Commit: https://github.com/mozilla-b2g/gaia/commit/83a6213f5d90ed650f9f891087d0fc1d34dee91e
Merged: https://github.com/mozilla-b2g/gaia/commit/e3fc29c5d4a9196b0e32e246f3d0150ae0c39221

Comment 12

[Evan Tseng [:evanxd]]

Thanks for Kevin's help. :)