Closed Bug 996470 Opened 11 years ago Closed 11 years ago

[NFC] Default NFC setting is ON

Categories

(Firefox OS Graveyard :: NFC, defect)

Product:
Firefox OS Graveyard
Component:
NFC
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(tracking-b2g:backlog)

Status:
VERIFIED FIXED
Milestone:
1.4 S6 (25apr)
Project Flags:
tracking-b2g backlog

People

(Reporter: ashiue, Assigned: allstars.chh)

References

Details

(Whiteboard: [p=1])

Attachments

(2 files)

[NFC] NFC Setting_20131118.pdf
663.09 KB, application/pdf
Details
Pull Request
46 bytes, text/x-github-pull-request
arthurcc
: review+
Details | Review
Using most up-to-date pvt build (2014/4/14) to test STR: 1. Flash up-to-date pvt build (2014/4/14) 2. Check "NFC" in Settings App Expected result: As UX design, NFC should turn off Actual result: NFC default turn on
Whiteboard: [FT:RIL]
Blocks: 904246
This change is the result of bug 969468. I don't know why this was merged, but I suggest to revert it.
We don't need the tag [ft:ril] as component=NFC is already on RIL team's radar.
blocking-b2g: --- → backlog
Whiteboard: [FT:RIL]
No longer blocks: 969468
Depends on: 969468
Garner, does your patch follow UX spec?
Flags: needinfo?(dgarnerlee)
Perhaps not if the spec says to disable by default. ashiue: can you provide a pointer to the UX doc that NFC should be disabled? We should keep a the 2 fixes to airplane mode, but the value itself can be flipped back easily.
Flags: needinfo?(dgarnerlee) → needinfo?(ashiue)
Garner, please refer page 6 in the attached UX doc. (To enable/disable NFC, tap the toggle to open/close it. - Default: disable)
Flags: needinfo?(ashiue)
I would suggest simply change the default value of "nfc.enabled" back to false here as the patch for bug 969468 also added some nfc checks.
Assignee: nobody → allstars.chh
Attached file Pull Request —
Attachment #8408119 - Flags: review?(arthur.chen)
Whiteboard: [p=1]
Target Milestone: --- → 1.4 S6 (25apr)
Hi Garner Just had a discussion with Arthur, when working on Gaia part, if you changed some UI or UX, you need to discuss with UX first. You cannot just file a bug and submit a patch. Thanks
Comment on attachment 8408119 [details] [review] Pull Request r=me, thanks.
Attachment #8408119 - Flags: review?(arthur.chen) → review+
master: 56969d68352b30e423d86ce7033b2a3aa95051bd
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
verified on 2014/4/20 pvt build
Status: RESOLVED → VERIFIED
blocking-b2g: backlog → ---
tracking-b2g: --- → backlog
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: