969468 - [B2G][NFC] Enable NFC preference by default

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Garner Lee]

It's a great UX idea to enable the user perference setting by default on device platforms that support it, when stable.

As of writing, that setting is in here:

config/common-settings.json

Comment 1

[Garner Lee]

Attachment: Enable NFC patch. r=arthurcc

The code is relatively stable now. 

Platforms compiled without NFC will be missing navigator.mozNfc, so the value doesn't matter (and won't show in UI). Enable NFC settings value and resulting functionality by default.

Comment 2

[Evelyn Hung]

Comment on attachment 8401614 [details] [review]
Enable NFC patch. r=arthurcc

I'd like to make sure the feature detection of NFC will work according to the comments above. redirect review flag to Arthur for verifying.

Comment 3

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8401614 [details] [review]
Enable NFC patch. r=arthurcc

Thanks for the patch! We should also check if mozNfc is available before changing the corresponding mozSettings value when toggling airplane mode.

Comment 4

[Garner Lee]

Comment on attachment 8401614 [details] [review]
Enable NFC patch. r=arthurcc

Hi Arthur (or Evelyn?):
Updated with extra dom check for mozNfc in airplane_mode.js as per comment. Passing green: https://github.com/mozilla-b2g/gaia/pull/17963

Comment 5

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8401614 [details] [review]
Enable NFC patch. r=arthurcc

r=me with the comment addressed. We should also add a check before suspending nfc.

Comment 6

[Garner Lee]

Thanks! Updated with last comment.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Master: https://github.com/mozilla-b2g/gaia/commit/e8f8c5d4da5599e00ae79b4bce5206f207d6feac