Closed Bug 996738 Opened 7 years ago Closed 7 years ago

LayerSorter.cpp doesn't play nicely with unified builds

Categories

(Core :: Graphics: Layers, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla31

People

(Reporter: kats, Assigned: kats)

References

Details

Attachments

(2 files)

While trying to implement bug 995411 I made some local changes and my debug build on mac desktop broke. Attached is the part of the build log that shows the failure - basically the color #defines in LayerSorter.cpp are messing with other files. I'm going to replace those defines with const int or something, per ehsan's suggestion.
Attached patch PatchSplinter Review
Comment on attachment 8406993 [details] [diff] [review]
Patch

Try build including this change pending at https://tbpl.mozilla.org/?tree=Try&rev=98ebef777331 (can't see it in the pushlog because I pushed it a different try push just before).
Attachment #8406993 - Flags: review?(matt.woodrow)
Attached file Build failure log
Apparently the build failure log I mentioned in comment 0 didn't attach. Here it is.
Attachment #8406993 - Flags: review?(matt.woodrow) → review+
https://hg.mozilla.org/mozilla-central/rev/c724358ef43f
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla31
Depends on: 1008360
You need to log in before you can comment on or make changes to this bug.