Closed
Bug 996738
Opened 11 years ago
Closed 11 years ago
LayerSorter.cpp doesn't play nicely with unified builds
Categories
(Core :: Graphics: Layers, defect)
Tracking
()
RESOLVED
FIXED
mozilla31
People
(Reporter: kats, Assigned: kats)
References
Details
Attachments
(2 files)
|
1.58 KB,
patch
|
mattwoodrow
:
review+
|
Details | Diff | Splinter Review |
|
1.00 KB,
text/plain
|
Details |
While trying to implement bug 995411 I made some local changes and my debug build on mac desktop broke. Attached is the part of the build log that shows the failure - basically the color #defines in LayerSorter.cpp are messing with other files. I'm going to replace those defines with const int or something, per ehsan's suggestion.
|
Assignee | |
Comment 1•11 years ago
|
||
|
|
Assignee | |
Comment 2•11 years ago
|
||
Comment on attachment 8406993 [details] [diff] [review]
Patch
Try build including this change pending at https://tbpl.mozilla.org/?tree=Try&rev=98ebef777331 (can't see it in the pushlog because I pushed it a different try push just before).
Attachment #8406993 -
Flags: review?(matt.woodrow)
|
|
Assignee | |
Comment 3•11 years ago
|
||
Apparently the build failure log I mentioned in comment 0 didn't attach. Here it is.
|
||
Updated•11 years ago
|
Attachment #8406993 -
Flags: review?(matt.woodrow) → review+
|
|
Assignee | |
Updated•11 years ago
|
Keywords: checkin-needed
|
||
Comment 4•11 years ago
|
||
Keywords: checkin-needed
|
|
||
Comment 5•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla31
You need to log in
before you can comment on or make changes to this bug.
Description
•