996914 - Breakdown: [New Tab Page] about:newtab should be unprivileged

Status: VERIFIED FIXED

(Firefox :: New Tab Page, defect)

Description

[Marco Mucci [:MarcoM]]

+++ This bug was initially created as a clone of Bug #776477 +++

Comment 1

[Matthew N. [:MattN]]

Mass-move to Firefox::New Tab Page.

Filter on new-tab-page-component.

Comment 2

[:Gijs (out for now; he/him)]

Tim, what exactly is necessary here? I would have figured:

1) switch page to use HTML instead of XUL (which is liable to still be a 13-point bug, but I suspect will be equally tricky to really split up more than that?). The RTL issue can be partially solved by setting the dir attribute on the root to the relevant entity value (IIRC this is what some of our other html about: pages do) - although obviously we might still need more CSS or other adjustments to make stuff work correctly.
2) update all the tests that we have
3) toggle the relevant bits for about:newtab in the about redirector

If this sounds right to you, I can file/repurpose all the relevant bugs and we can close this one...

Comment 3

[Tim Taubert [:ttaubert] (inactive)]

Another somewhat difficult part is rewriting all the logic in NewTabUtils.jsm to work with Events like the new search input does. The whole page isn't e10s ready at all and thus currently requires chrome privs to load pinned sites etc. Another 13-point bug here...

Comment 4

[:Gijs (out for now; he/him)]

Marco, can you add this to this iteration's backlog?

Comment 5

[:Gijs (out for now; he/him)]

Filed bug 1021653, bug 1021654, bug 1021667.

Comment 6

[Marco Mucci [:MarcoM]]

Added to Iteration 32.3