Tested commercial 2001-09-14-09-trunk nt 4.0 2001-09-14-08-trunk linux 2.2, mac 9.1 David, I think this is a regression. I noticed when I selected mesg(s) in messenger and went to file|Offline|Get selected messages it did not download those messages. These messages were ordinary text mesgs and were 1kb in size. 'Get flagged messages' works fine. I'm not sure which bug might have caused this. I did a little regression testing on windows and linux builds. The last trunk builds that 'get selected messages' was working in was the 9-12-08 on linux and 9-12-09 (2001091203) on windows. The 9-13-08 (linux) and 9-13-05 (windows) is when 'get selected messages' was first broken in. I looked at any related offline bugs and the only ones that were checked into the trunk were bug 79245 and bug 91352. I don't think these had an affect on "get selected messages" but not sure.
botched patch application, unfortunately. Fix is to put the code back the way it was. The branch is now busted the patch was checked into the branch too. Cc'ing Seth and Navin for review, nominating for branch.
Status: NEW → ASSIGNED
Gotta fix this. Sorry jaime, nsbranch+ and PDT.
Keywords: nsbranch → nsbranch+
fix checked into trunk. waiting for approval from pdt for branch checkin.
Comment on attachment 49838 [details] [diff] [review] proposed fix r=naving, sr=sspitzer
Severity: normal → major
Priority: -- → P1
Target Milestone: --- → mozilla0.9.5
Looks like this one is a nsenterprise requirement per Hong. MScott/Hong - Pls come by @ noon to tell us why this is tastey, and good eats for today.
This is a no brainer, put it in. PDT+
Whiteboard: PDT → PDT+
fixed on branch
Status: ASSIGNED → RESOLVED
Last Resolved: 18 years ago
Resolution: --- → FIXED
Verified on Commercial branch builds 2001-09-19-05-0.9.4/ win nt 4.0 2001-09-19-04-0.9.4/ linux 2.2 2001-09-19-08-0.9.4/ mac 9.1 2001-09-19-04-0.9.4/ mac 10.0.4 Get selected messages does work. Adding vtrunk to keyword.
commercial trunk 2001-10-08-09-trunk NT 4.0 2001-10-08-08-trunk linux 2.2 2001-10-08-08-trunk mac 9.1 verified 'get selected messages' works. Removing keyword vtrunk marking as verified.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.