997059 - [Tarako] Make image cropper in the gallery picker configurable, and disable it in tarako

Status: RESOLVED INVALID

(Firefox OS Graveyard :: Gaia::Gallery, defect)

Description

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Please read bug 992505, and maybe bug 996141.

Our current image cropper implementation takes too much memory and triggers OOM a lot when being used in the picker. Confirmed with Marvin offline, we decided to turn off the the image cropper in the gallery picker for tarako. John will help to make a switch for build time customization.

To workaround this missing feature the user is encouraged to use the standalone "edit" feature in Gallery app to crop the image, before going to other app and use the picker.

Comment 1

[Joe Cheng [:jcheng] (please needinfo)]

triage: 1.3T+ per discussion with Product

Comment 2

[John Hu [:johnhu][:johu][:醬糊小弟]]

Attachment: 1.3t: add no crop config to build-time customization.

Add a new config called CONFIG_NO_CROP_TOOL_IN_PICKER. When this value is true, we don't crop the image and return file-based blob reference.

This patch will only be landed to 1.3t.

Comment 3

[Tim Guan-tin Chien [:timdream] (please needinfo)]

(In reply to John Hu [:johnhu][:johu][:醬糊小弟] from comment #2)
> This patch will only be landed to 1.3t.

We should land it on all branches since it's switchable.

Comment 4

[David Flanagan [:djf]]

I'm not sure this makes sense.  In bug 989290 I'm working on rotating images when they are picked. If the Tarako camera driver continues to use EXIF image orientation, any pick activity for a portrait mode photo will require more memory than cropping does.  

So unless we can solve the EXIF orientation issue, I don't think it makes sense to remove cropping.

I'm going to see what happens with my 989290 patch before reviewing this one.

Comment 5

[John Hu [:johnhu][:johu][:醬糊小弟]]

Attachment: master: add no crop in picker config

Comment 6

[John Hu [:johnhu][:johu][:醬糊小弟]]

as per bug 995149 comment 17, the cropper tool works fine in 2MP limitation. We don't need to remove it.