Closed Bug 997751 Opened 9 years ago Closed 9 years ago

[HOMESCREEN] Remove 'power' permission from homescreen manifest.

Categories

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Homescreen
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
1.4 S6 (25apr)

People

(Reporter: GaryChen, Assigned: kgrandon)

References

Details

(Whiteboard: [p=1],[systemsfe])

Attachments

(1 file)

Github pull request
46 bytes, text/x-github-pull-request
GaryChen
: review+
Details | Review 
:lchang and I trace 'homescreen' app , we found there is no longer using 'navigator.mozPower' in 'homescreen' app.
Seems we can remove it for cleaning up manifest.
Please check bug 871243, the original bug who add 'power' permission in 'homescreen' app.
Hey Guys - thanks for filing this. I'm doing a permissions review for the new homescreen2 prototype and it would be good to get this cleaned up. I'll go ahead and submit a patch here if no one else is working on this. Thanks!
Assignee: nobody → kgrandon
Status: NEW → ASSIGNED
Whiteboard: [p=1],[systemsfe]
Target Milestone: --- → 1.4 S6 (25apr)
Attached file Github pull request — 

        Attachment #8409485 -
        Flags: review?(gchen)

        Attachment #8409485 -
        Flags: review?(crdlc)

    
  
See Also:  → 998810

    
    

    
  
Comment on attachment 8409485 [details] [review]
Github pull request

r=me, thanks for your nice work.

        Attachment #8409485 -
        Flags: review?(gchen) → review+

    
    

    
  
Comment on attachment 8409485 [details] [review]
Github pull request

Let's go with gary's review. Cristian - if you have any concerns feel free to reopen/ping me.

        Attachment #8409485 -
        Flags: review?(crdlc)

    
    

    
  
Landed: https://github.com/mozilla-b2g/gaia/commit/2b8464de5f54ec706cffb29c029fa11f6c515dcc
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED

          You need to log in
          before you can comment on or make changes to this bug.