998810 - [Homescreen] alarms permission seems unneeded

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

Description

[Kevin Grandon :kgrandon]

Like bug 997751, the alarms permission seems like it is no longer needed in the manifest.

This was added in bug 871243, and it appears to have been added to hit the internet again when there was no network connection. I don't know the exact strategy now, but there is no usage of mozAlarm in the homescreen app - so it seems safe to remove this.

Comment 1

[Kevin Grandon :kgrandon]

Attachment: Github pull request

Comment 2

[Cristian Rodriguez (:crdlc)]

It was used in ev.me, Ran, can it be deleted, right?

Comment 3

[Kevin Grandon :kgrandon]

Comment on attachment 8409486 [details] [review]
Github pull request

Can I mark one of you guys as a reviewer? When grepping for 'alarms', no results are found so I think we can remove this one.

Comment 4

[Cristian Rodriguez (:crdlc)]

Comment on attachment 8409486 [details] [review]
Github pull request

I think so but AFAIR ev.me added it some months ago but I think that it was removed after rocketbar work or before

Comment 5

[Ran Ben Aharon [:ranbena] EverythingMe]

Comment on attachment 8409486 [details] [review]
Github pull request

It's related to a feature introduced in Bug 871243 and was later removed in Bug 910316. Thanks!

Comment 6

[Kevin Grandon :kgrandon]

Thanks for the review! Landed: https://github.com/mozilla-b2g/gaia/commit/985a9523fe17df1a3ada56ba178d603100c1f7f9