Closed Bug 998810 Opened 7 years ago Closed 7 years ago

[Homescreen] alarms permission seems unneeded

Categories

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
1.4 S6 (25apr)

People

(Reporter: kgrandon, Assigned: kgrandon)

References

Details

(Whiteboard: [systemsfe])

Attachments

(1 file)

46 bytes, text/x-github-pull-request
ranbena
: review+
Details | Review
Like bug 997751, the alarms permission seems like it is no longer needed in the manifest.

This was added in bug 871243, and it appears to have been added to hit the internet again when there was no network connection. I don't know the exact strategy now, but there is no usage of mozAlarm in the homescreen app - so it seems safe to remove this.
Attached file Github pull request
It was used in ev.me, Ran, can it be deleted, right?
Flags: needinfo?(ran)
Comment on attachment 8409486 [details] [review]
Github pull request

Can I mark one of you guys as a reviewer? When grepping for 'alarms', no results are found so I think we can remove this one.
Attachment #8409486 - Flags: review?(ran)
Attachment #8409486 - Flags: review?(crdlc)
Flags: needinfo?(ran)
Comment on attachment 8409486 [details] [review]
Github pull request

I think so but AFAIR ev.me added it some months ago but I think that it was removed after rocketbar work or before
Attachment #8409486 - Flags: review?(crdlc)
Comment on attachment 8409486 [details] [review]
Github pull request

It's related to a feature introduced in Bug 871243 and was later removed in Bug 910316. Thanks!
Attachment #8409486 - Flags: review?(ran) → review+
Thanks for the review! Landed: https://github.com/mozilla-b2g/gaia/commit/985a9523fe17df1a3ada56ba178d603100c1f7f9
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Whiteboard: [systemsfe]
You need to log in before you can comment on or make changes to this bug.