Closed Bug 997996 Opened 7 years ago Closed 7 years ago

Make ToolbarComponent.dismissEditingMode use the cancel editing mode button

Categories

(Firefox for Android Graveyard :: Testing, defect)

All
Android
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 31

People

(Reporter: mcomella, Assigned: vivek)

References

Details

(Whiteboard: [mentor=mcomella][lang=java])

Attachments

(1 file)

Hit the url, hit the X, make sure editing mode is cancelled.
Note that if bug 997447 is not implemented yet, this test will need to be guarded to run on phones only.

Since this method of dismissing editing mode is preferable to the one in ToolbarComponent.dismissEditingMode, use the cancel button there, and add a test for the current methodology instead of what comment 0 declares.
Summary: Add cancel editing mode button test → Make ToolbarComponent.dismissEditingMode use the cancel editing mode button
I would like to work on this
Sure - you've been assigned! The information in comment 0 and comment 1 should be enough to complete this bug. If anything is unclear or insufficient, please let me know!

Good luck!
Assignee: nobody → vivekb.balakrishnan
Status: NEW → ASSIGNED
Attached patch 997996.patchSplinter Review
As per discussion over irc, ToolbarComponent.dismissEditingMode uses the close button in phones. existing method of hitting Back button twice retained for tablets.
Attachment #8409812 - Flags: review?(michael.l.comella)
Comment on attachment 8409812 [details] [diff] [review]
997996.patch

Review of attachment 8409812 [details] [diff] [review]:
-----------------------------------------------------------------

Nice, lgtm!

Do you mind following a dependent followup for implementing this on tablet, and CCing me? :)
Attachment #8409812 - Flags: review?(michael.l.comella) → review+
Blocks: 999211
No longer depends on: 999211
Keywords: checkin-needed
https://hg.mozilla.org/integration/fx-team/rev/162b121760e1
Keywords: checkin-needed
Whiteboard: [mentor=mcomella][lang=java] → [mentor=mcomella][lang=java][fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/162b121760e1
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Whiteboard: [mentor=mcomella][lang=java][fixed-in-fx-team] → [mentor=mcomella][lang=java]
Target Milestone: --- → Firefox 31
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.