Closed
Bug 999211
Opened 11 years ago
Closed 11 years ago
Implement cancel editing mode button test on tablet
Categories
(Firefox for Android Graveyard :: Testing, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 33
People
(Reporter: vivek, Assigned: vivek, Mentored)
References
Details
(Whiteboard: [lang=java])
Attachments
(1 file)
|
1.30 KB,
patch
|
mcomella
:
review+
|
Details | Diff | Splinter Review |
User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Ubuntu Chromium/33.0.1750.152 Chrome/33.0.1750.152 Safari/537.36
Steps to reproduce:
Enter a Url, X button should be displayed to cancel editing. Upon hitting X, make sure editing mode is cancelled
Expected results:
This is a followup bug for 997996 and is reliable method to dismiss edit mode
|
Assignee | |
Updated•11 years ago
|
OS: Linux → Android
Hardware: x86_64 → All
Spoke with vivek on IRC - he'll take care of this once bug 997477 lands (bug 997996 should be landing now).
Assignee: nobody → vivekb.balakrishnan
Status: NEW → ASSIGNED
Summary: Implement cancel editing mode button in tablets → Implement cancel editing mode button test on tablet
Vivek, bug 997477 just landed so if it sticks, you can go ahead with this one!
Flags: needinfo?(vivekb.balakrishnan)
|
|
Assignee | |
Comment 3•11 years ago
|
||
Thanks Michael, I will intimate you after updating a patch.
Flags: needinfo?(vivekb.balakrishnan)
|
|
Assignee | |
Comment 4•11 years ago
|
||
Try server Logs:
https://tbpl.mozilla.org/?tree=Try&rev=6c8d97dfcbf1
Attachment #8440315 -
Flags: review?(michael.l.comella)
Comment on attachment 8440315 [details] [diff] [review]
999211.patch
Review of attachment 8440315 [details] [diff] [review]:
-----------------------------------------------------------------
lgtm
Attachment #8440315 -
Flags: review?(michael.l.comella) → review+
|
|
Assignee | |
Updated•11 years ago
|
Keywords: checkin-needed
|
||
Comment 6•11 years ago
|
||
Keywords: checkin-needed
Whiteboard: [mentor=mcomella][lang=java] → [mentor=mcomella][lang=java][fixed-in-fx-team]
|
||
Updated•11 years ago
|
Mentor: michael.l.comella
Whiteboard: [mentor=mcomella][lang=java][fixed-in-fx-team] → [lang=java][fixed-in-fx-team]
|
|
||
Comment 7•11 years ago
|
||
Mentor: michael.l.comella
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [lang=java][fixed-in-fx-team] → [lang=java]
Target Milestone: --- → Firefox 33
|
||
Updated•5 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•