Closed Bug 998911 Opened 6 years ago Closed 6 years ago

[Settings] visual update for the volume sliders in sound region

Categories

(Firefox OS Graveyard :: Gaia::Settings, defect)

ARM
Gonk (Firefox OS)
defect
Not set

Tracking

(feature-b2g:2.0, b2g-v2.0 fixed)

RESOLVED FIXED
2.0 S2 (23may)
feature-b2g 2.0
Tracking Status
b2g-v2.0 --- fixed

People

(Reporter: dkuo, Assigned: dkuo)

References

Details

(Whiteboard: [good first bug][mentor=dkuo] ux-tracking, visual design, visual-tracking, bokken [p=1])

Attachments

(3 files)

We will have visual update for the icons of the volume sliders in the sound region, and visual team will attach the new images here, let's do the ui-review and trace this issue here.
Whiteboard: [good first bug][mentor=dkuo] ux-tracking, visual design, visual-tracking, bokken → [good first bug][mentor=dkuo] ux-tracking, visual design, visual-tracking, bokken [p=1]
Target Milestone: --- → 2.0 S1 (9may)
Assignee: nobody → dkuo
Hi Carol, could you provide the new images for the volume sliders? Thank you.
Flags: needinfo?(chuang)
Please see Bug 991026 for the latest UX spec.
Hi guys,
I uploaded the visual spec for the new layout in Volume adjustment. Please take a look and let me know if you have any question.
Flags: needinfo?(chuang)
Target Milestone: 2.0 S1 (9may) → 2.0 S2 (23may)
Carol, this is the screenshot after the patch is applied(including the RTL version), would you please review it? thanks.
Attachment #8422233 - Flags: ui-review?(chuang)
Let's also have the peer to review this, Arthur, would you please review this? thanks.
Attachment #8422236 - Flags: review?(arthur.chen)
Comment on attachment 8422233 [details]
Screenshot: volume sliders visual update

Hey Dominic,
It looks pretty good! Great work, thanks!
Attachment #8422233 - Flags: ui-review?(chuang) → ui-review+
(In reply to chuang from comment #6)
> Comment on attachment 8422233 [details]
> Screenshot: volume sliders visual update
> 
> Hey Dominic,
> It looks pretty good! Great work, thanks!

Thanks Carol! and note the "Media" text is not localized because it's a new feature in 2.0, the localized strings will be available after 2.0 is branched or in the production build, it's not related to our visual update.
(In reply to Dominic Kuo [:dkuo] from comment #7)
> (In reply to chuang from comment #6)
> > Comment on attachment 8422233 [details]
> > Screenshot: volume sliders visual update
> > 
> > Hey Dominic,
> > It looks pretty good! Great work, thanks!
> 
> Thanks Carol! and note the "Media" text is not localized because it's a new
> feature in 2.0, the localized strings will be available after 2.0 is
> branched or in the production build, it's not related to our visual update.

Got it! thanks for letting me know :)
Comment on attachment 8422236 [details] [review]
Patch: Visual update for the volume sliders in sound region

r=me, thanks! Please squash the commits and compress the images with the tool before merging.
Attachment #8422236 - Flags: review?(arthur.chen) → review+
Thanks Arthur!

Landed on master: da2e4d2078d19b092ad135e0173ae4a7a480e823
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
feature-b2g: --- → 2.0
You need to log in before you can comment on or make changes to this bug.