Closed
Bug 999138
Opened 10 years ago
Closed 10 years ago
Clean up bootstrap mozL10n API use in Clock
Categories
(Firefox OS Graveyard :: Gaia::Clock, defect)
Firefox OS Graveyard
Gaia::Clock
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: zbraniecki, Assigned: zbraniecki)
References
Details
Attachments
(1 file)
Clock app relies in multiple places on mozL10n API. We should update those use cases to proper mozL10n API's. - js/startup.js mozL10n.ready => mozL10n.once - js/ring_view.js mozL10n.ready => mozL10n.once - js/alarm_edit/main.js event@localied => mozL10n.ready - js/app.js onlocalized => null
Assignee | ||
Comment 1•10 years ago
|
||
Assignee: nobody → gandalf
Status: NEW → ASSIGNED
Assignee | ||
Comment 2•10 years ago
|
||
This should actually wait for the fix in mozL10n.ready.
Assignee | ||
Comment 3•10 years ago
|
||
Comment on attachment 8409840 [details] [review] pull request Corey, can you review my patch?
Attachment #8409840 -
Flags: review?(gnarf37)
Assignee | ||
Comment 4•10 years ago
|
||
I modified tests that were manually firing 'localized' event to instead emulate language change.
Assignee | ||
Comment 5•10 years ago
|
||
On an unrelated note - do we really have to wait 25000ms before we start this test? https://github.com/mozilla-b2g/gaia/blob/master/apps/clock/test/unit/panels/alarm_edit/alarm_edit_test.js#L9 - I'm wondering how it adds up to how long the test suite takes to complete.
Comment 6•10 years ago
|
||
That does not actually wait 25 seconds; it merely indicates to Mocha, the test runner, that it shouldn't flag tests shorter than 25s as 'slow' (orange or yellow or whatever) in the test reporting.
Assignee | ||
Comment 7•10 years ago
|
||
ah, thanks!
Assignee | ||
Comment 8•10 years ago
|
||
Comment on attachment 8409840 [details] [review] pull request Trying a different reviewer
Attachment #8409840 -
Flags: review?(gnarf37) → review?(mike)
Assignee | ||
Comment 9•10 years ago
|
||
Vivien, can you help me find a reviewer for this patch?
Flags: needinfo?(21)
Comment 10•10 years ago
|
||
Comment on attachment 8409840 [details] [review] pull request I assume Marcus is the right guy for that ? In the worst case he is the owner of the app, and should be able to redirect to the right person.
Attachment #8409840 -
Flags: review?(mike) → review?(m)
Flags: needinfo?(21)
Comment 11•10 years ago
|
||
Comment on attachment 8409840 [details] [review] pull request Looks good to me.
Attachment #8409840 -
Flags: review?(m) → review+
Assignee | ||
Comment 12•10 years ago
|
||
Patch: https://github.com/mozilla-b2g/gaia/commit/38eb37cdadb90f19bef2cd4a3eeea539a046fadb Merge: https://github.com/mozilla-b2g/gaia/commit/c3362b4f36173483ae001ab567aced258ca91afb Thanks!
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•