Closed Bug 999138 Opened 10 years ago Closed 10 years ago

Clean up bootstrap mozL10n API use in Clock

Categories

(Firefox OS Graveyard :: Gaia::Clock, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: zbraniecki, Assigned: zbraniecki)

References

Details

Attachments

(1 file)

Clock app relies in multiple places on mozL10n API. We should update those use cases to proper mozL10n API's.

 - js/startup.js mozL10n.ready => mozL10n.once
 - js/ring_view.js mozL10n.ready => mozL10n.once
 - js/alarm_edit/main.js event@localied => mozL10n.ready
 - js/app.js onlocalized => null
Blocks: 993188
Attached file pull request
Assignee: nobody → gandalf
Status: NEW → ASSIGNED
This should actually wait for the fix in mozL10n.ready.
No longer blocks: 993188
Depends on: 993188
Blocks: 1000593
Comment on attachment 8409840 [details] [review]
pull request

Corey, can you review my patch?
Attachment #8409840 - Flags: review?(gnarf37)
I modified tests that were manually firing 'localized' event to instead emulate language change.
On an unrelated note - do we really have to wait 25000ms before we start this test? https://github.com/mozilla-b2g/gaia/blob/master/apps/clock/test/unit/panels/alarm_edit/alarm_edit_test.js#L9 - I'm wondering how it adds up to how long the test suite takes to complete.
That does not actually wait 25 seconds; it merely indicates to Mocha, the test runner, that it shouldn't flag tests shorter than 25s as 'slow' (orange or yellow or whatever) in the test reporting.
ah, thanks!
No longer depends on: 993188
Comment on attachment 8409840 [details] [review]
pull request

Trying a different reviewer
Attachment #8409840 - Flags: review?(gnarf37) → review?(mike)
Vivien, can you help me find a reviewer for this patch?
Flags: needinfo?(21)
Comment on attachment 8409840 [details] [review]
pull request

I assume Marcus is the right guy for that ?
In the worst case he is the owner of the app, and should be able to redirect to the right person.
Attachment #8409840 - Flags: review?(mike) → review?(m)
Flags: needinfo?(21)
Comment on attachment 8409840 [details] [review]
pull request

Looks good to me.
Attachment #8409840 - Flags: review?(m) → review+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: