999138 - Clean up bootstrap mozL10n API use in Clock

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Clock, defect)

Description

[Zibi Braniecki [:zbraniecki][:gandalf]]

Clock app relies in multiple places on mozL10n API. We should update those use cases to proper mozL10n API's.

 - js/startup.js mozL10n.ready => mozL10n.once
 - js/ring_view.js mozL10n.ready => mozL10n.once
 - js/alarm_edit/main.js event@localied => mozL10n.ready
 - js/app.js onlocalized => null

Comment 1

[Zibi Braniecki [:zbraniecki][:gandalf]]

Attachment: pull request

Comment 2

[Zibi Braniecki [:zbraniecki][:gandalf]]

This should actually wait for the fix in mozL10n.ready.

Comment 3

[Zibi Braniecki [:zbraniecki][:gandalf]]

Comment on attachment 8409840 [details] [review]
pull request

Corey, can you review my patch?

Comment 4

[Zibi Braniecki [:zbraniecki][:gandalf]]

I modified tests that were manually firing 'localized' event to instead emulate language change.

Comment 5

[Zibi Braniecki [:zbraniecki][:gandalf]]

On an unrelated note - do we really have to wait 25000ms before we start this test? https://github.com/mozilla-b2g/gaia/blob/master/apps/clock/test/unit/panels/alarm_edit/alarm_edit_test.js#L9 - I'm wondering how it adds up to how long the test suite takes to complete.

Comment 6

[Marcus Cavanaugh [:mcav]]

That does not actually wait 25 seconds; it merely indicates to Mocha, the test runner, that it shouldn't flag tests shorter than 25s as 'slow' (orange or yellow or whatever) in the test reporting.

Comment 7

[Zibi Braniecki [:zbraniecki][:gandalf]]

ah, thanks!

Comment 8

[Zibi Braniecki [:zbraniecki][:gandalf]]

Comment on attachment 8409840 [details] [review]
pull request

Trying a different reviewer

Comment 9

[Zibi Braniecki [:zbraniecki][:gandalf]]

Vivien, can you help me find a reviewer for this patch?

Comment 10

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 8409840 [details] [review]
pull request

I assume Marcus is the right guy for that ?
In the worst case he is the owner of the app, and should be able to redirect to the right person.

Comment 11

[Marcus Cavanaugh [:mcav]]

Comment on attachment 8409840 [details] [review]
pull request

Looks good to me.

Comment 12

[Zibi Braniecki [:zbraniecki][:gandalf]]

Patch: https://github.com/mozilla-b2g/gaia/commit/38eb37cdadb90f19bef2cd4a3eeea539a046fadb
Merge: https://github.com/mozilla-b2g/gaia/commit/c3362b4f36173483ae001ab567aced258ca91afb

Thanks!