999155 - Clean up bootstrap mozL10n API use in Contacts

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Zibi Braniecki [:zbraniecki][:gandalf]]

Contacts code manually sets document's dir/lang which is done automatically by l10n.js.

Comment 1

[Zibi Braniecki [:zbraniecki][:gandalf]]

Attachment: pull request

Comment 2

[Zibi Braniecki [:zbraniecki][:gandalf]]

There also was a manual emulation of mozL10n.once, fixed in updated pull request

Comment 3

[Zibi Braniecki [:zbraniecki][:gandalf]]

Comment on attachment 8409845 [details] [review]
pull request

Jose, can you look at this patch? (bmo pointed you as a suggested reviewer)

Comment 4

[Jose Manuel Cantera]

Comment on attachment 8409845 [details] [review]
pull request

the code looks good to me but handing over to Francisco as he created the original l10n infra for contacts

thanks!

Comment 5

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8409845 [details] [review]
pull request

LGTM,

tried on the phone and working perfect, with cold launch, activities, and language change via settings.

Thanks a lot!

Comment 6

[Francisco Jordano [:arcturus] [:francisco]]

Landed:

https://github.com/zbraniecki/gaia/commit/294dddec48e317793b05dc288e2f360a58135c9e