Closed Bug 999436 Opened 6 years ago Closed 6 years ago

Solve IMPORT dependencies before moving it to shared

Categories

(Firefox OS Graveyard :: Gaia::First Time Experience, defect)

x86
macOS
defect
Not set

Tracking

(b2g-v2.0 fixed)

RESOLVED FIXED
1.4 S6 (25apr)
Tracking Status
b2g-v2.0 --- fixed

People

(Reporter: fcampo, Assigned: fcampo)

References

Details

Attachments

(3 files)

Before any attempt on moving the import.html (key to importing from  any internet service) to shared folder, we need to solve all the dependencies from the html (heavily linked to communications folder).

We might need to move a lot more utilities, locales and modify the build process for this.

Best approach is to solve it with different small and manageable pull requests.
Attached file Part 1: Locales - PR
Attachment #8410271 - Flags: review?(jmcf)
Attached file Part 2: Utilities - PR
Attachment #8410362 - Flags: review?(jmcf)
Comment on attachment 8410271 [details] [review]
Part 1: Locales - PR

thanks
Attachment #8410271 - Flags: review?(jmcf) → review+
Target Milestone: --- → 1.4 S6 (25apr)
Attachment #8411042 - Flags: review?(jmcf)
Comment on attachment 8410362 [details] [review]
Part 2: Utilities - PR

please merge once Travis is green
Attachment #8410362 - Flags: review?(jmcf) → review+
Part 2 merged on master - b23d372077f5be777875b8e5eebde391af6eb6aa
Comment on attachment 8411042 [details] [review]
Part 3: Contacts .js files - PR

please merge once Travis is green
Attachment #8411042 - Flags: review?(jmcf) → review+
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Depends on: 1001488
This broke contacts import entirely. Can you backout?
Flags: needinfo?(fernando.campo)
We think is better to provide a quick patch fixing the issue, backout would be way more painful.

Jose is already working on it, and we'll try to land it in a while.
Flags: needinfo?(fernando.campo)
You need to log in before you can comment on or make changes to this bug.