999436 - Solve IMPORT dependencies before moving it to shared

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::First Time Experience, defect)

Description

[Fernando Campo (:fcampo)]

Before any attempt on moving the import.html (key to importing from  any internet service) to shared folder, we need to solve all the dependencies from the html (heavily linked to communications folder).

We might need to move a lot more utilities, locales and modify the build process for this.

Best approach is to solve it with different small and manageable pull requests.

Comment 1

[Fernando Campo (:fcampo)]

Attachment: Part 1: Locales - PR

Comment 2

[Fernando Campo (:fcampo)]

Attachment: Part 2: Utilities - PR

Comment 3

[Jose Manuel Cantera]

Comment on attachment 8410271 [details] [review]
Part 1: Locales - PR

thanks

Comment 4

[Jose Manuel Cantera]

Part I landed: https://github.com/fcampo/gaia/commit/23886e4bd3edd57455e56dcc3cc8ec2204539694

Comment 5

[Fernando Campo (:fcampo)]

Attachment: Part 3: Contacts .js files - PR

Comment 6

[Jose Manuel Cantera]

Comment on attachment 8410362 [details] [review]
Part 2: Utilities - PR

please merge once Travis is green

Comment 7

[Fernando Campo (:fcampo)]

Part 2 merged on master - b23d372077f5be777875b8e5eebde391af6eb6aa

Comment 8

[Jose Manuel Cantera]

Comment on attachment 8411042 [details] [review]
Part 3: Contacts .js files - PR

please merge once Travis is green

Comment 9

[Jose Manuel Cantera]

part 3 landed in master:

https://github.com/fcampo/gaia/commit/309dd611740d3e8eca34797bfc420c92e653fcc1

Comment 10

[Jason Smith [:jsmith]]

This broke contacts import entirely. Can you backout?

Comment 11

[Fernando Campo (:fcampo)]

We think is better to provide a quick patch fixing the issue, backout would be way more painful.

Jose is already working on it, and we'll try to land it in a while.