Closed Bug 999462 Opened 10 years ago Closed 10 years ago

Support HTTP cache v2 API in the UI

Categories

(SeaMonkey :: Preferences, defect)

Product:
SeaMonkey
Component:
Preferences
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(seamonkey2.28? fixed)

Status:
RESOLVED FIXED
Milestone:
seamonkey2.29
Tracking Flags:
Tracking Status
seamonkey2.28 ? fixed

People

(Reporter: neil, Assigned: neil)

References

Details

Attachments

(1 file, 3 obsolete files)

Proposed patch
2.90 KB, patch
mcsmurf
: review+
Details | Diff | Splinter Review 
The code used by bug 975362 to display the cache size does not actually work with the v2 API. Bug 915296 subsequently created a new API to display the v2 cache size correctly. (This API itself calls the old API for the old cache.)

Note that as per bug 998445 you have to wait for a minute after startup for the v2 cache to load its index before it will display the size. Unlike bug 998445 we simply display nothing so it's not so obvious that anything is broken.
Attached patch WIP (obsolete) — — Splinter Review 
This just does the cache pref panel.
Assignee: nobody → neil
Status: NEW → ASSIGNED
Attached patch WIP (obsolete) — — Splinter Review 
This is what the patch would look like if offline apps used a similar API.

Except I just noticed that its API hasn't changed.

At least, not yet.
Attachment #8410286 - Attachment is obsolete: true
Attached patch WIP (obsolete) — — Splinter Review 
In fact the v2 API doesn't even work for offline apps. Oops.
Attachment #8410293 - Attachment is obsolete: true
Attached patch Proposed patch — — Splinter Review 
Well this part does at least work, which is something.
Attachment #8410307 - Attachment is obsolete: true
Attachment #8410309 - Flags: review?(bugzilla)
Looks like Bug 998445 fixed...something, not sure what exactly.
Comment on attachment 8410309 [details] [diff] [review]
Proposed patch

Looks good, works fine with both old and new cache. I could not observe the delay talked about in the other bug, but then something seems to have been fixed there.
Attachment #8410309 - Flags: review?(bugzilla) → review+
Pushed comm-central changeset 3d39586bb472.
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.29
Do you think we need this in TB too?
(In reply to aceman from comment #8)
> Do you think we need this in TB too?

I don't know what cache UI you have but it all needs to be updated to use the v2 APIs. (The v2 APIs call the v1 APIs if the v2 cache is disabled in about:config)
a=me for SeaMonkey 2.28
status-seamonkey2.28: --- → affected
tracking-seamonkey2.28: --- → ?
Depends on: 1061990
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: