Add --browser-arg to B2G desktop mozharness script

RESOLVED FIXED

Status

defect
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: jgriffin, Assigned: jgriffin)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 1 obsolete attachment)

We should add support for the --browser-arg mochitest CLI to the mozharness script for B2G desktop mochitests.  We can use this to pass -oop to the build to get it to start in OOP mode, once bug 998500 lands.

I've already tested that the B2G mochitest framework correctly handles --browser-arg for B2G desktop tests.
Attachment #8410567 - Flags: review?(ahalberstadt)
Hmm, looks like I'll need to add support for --browser-arg to reftests.
I'll also need to handle this in our Gaia mozharness files.  Patch in progress.
Attachment #8410579 - Flags: review?(ahalberstadt)
New version which includes Marionette support
Attachment #8410593 - Flags: review?(ahalberstadt)
Attachment #8410567 - Attachment is obsolete: true
Attachment #8410567 - Flags: review?(ahalberstadt)
Comment on attachment 8410579 [details] [diff] [review]
Add --browser-arg support to mochitest/reftest on B2G desktop builds,

Review of attachment 8410579 [details] [diff] [review]:
-----------------------------------------------------------------

Lgtm!
Attachment #8410579 - Flags: review?(ahalberstadt) → review+
Comment on attachment 8410593 [details] [diff] [review]
Add browser-arg support to B2G desktop scripts,

Review of attachment 8410593 [details] [diff] [review]:
-----------------------------------------------------------------

Lgtm, with minor nit.

::: scripts/marionette.py
@@ +435,5 @@
>              cmd.extend(self._build_arg('--binary', binary))
>              cmd.extend(self._build_arg('--address',
>                                         self.config['marionette_address']))
> +            if self.config.get('app_arg'):
> +                cmd.extend(self._build_arg('--app-arg', self.config['app_arg']))

_build_arg() handles the case where the value is None, so you can get rid of this if statement and s/config['app_arg']/config.get('app_arg')
Attachment #8410593 - Flags: review?(ahalberstadt) → review+
Comment on attachment 8410579 [details] [diff] [review]
Add --browser-arg support to mochitest/reftest on B2G desktop builds,

Removed the _build_arg() call and landed the mozharness piece:  https://hg.mozilla.org/build/mozharness/rev/77c9ccf077b0
Attachment #8410579 - Flags: checked-in+
mozharness patch live in production: http://hg.mozilla.org/build/mozharness/rev/d5a7c46032fe :)
https://hg.mozilla.org/mozilla-central/rev/9c4a9fe63542
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Blocks: 1001025
Component: General Automation → Mozharness
You need to log in before you can comment on or make changes to this bug.