999723 - Add --browser-arg to B2G desktop mozharness script

Status: RESOLVED FIXED

(Release Engineering :: Applications: MozharnessCore, defect)

Description

[Jonathan Griffin (:jgriffin)]

We should add support for the --browser-arg mochitest CLI to the mozharness script for B2G desktop mochitests.  We can use this to pass -oop to the build to get it to start in OOP mode, once bug 998500 lands.

I've already tested that the B2G mochitest framework correctly handles --browser-arg for B2G desktop tests.

Comment 1

[Jonathan Griffin (:jgriffin)]

Attachment: Add --browser-arg support to mozharness script,

Comment 2

[Jonathan Griffin (:jgriffin)]

Hmm, looks like I'll need to add support for --browser-arg to reftests.

Comment 3

[Jonathan Griffin (:jgriffin)]

Attachment: Add --browser-arg support to mochitest/reftest on B2G desktop builds,

I'll also need to handle this in our Gaia mozharness files.  Patch in progress.

Comment 4

[Jonathan Griffin (:jgriffin)]

Attachment: Add browser-arg support to B2G desktop scripts,

New version which includes Marionette support

Comment 5

[Andrew Halberstadt [:ahal]]

Comment on attachment 8410579 [details] [diff] [review]
Add --browser-arg support to mochitest/reftest on B2G desktop builds,

Review of attachment 8410579 [details] [diff] [review]:
-----------------------------------------------------------------

Lgtm!

Comment 6

[Andrew Halberstadt [:ahal]]

Comment on attachment 8410593 [details] [diff] [review]
Add browser-arg support to B2G desktop scripts,

Review of attachment 8410593 [details] [diff] [review]:
-----------------------------------------------------------------

Lgtm, with minor nit.

::: scripts/marionette.py
@@ +435,5 @@
>              cmd.extend(self._build_arg('--binary', binary))
>              cmd.extend(self._build_arg('--address',
>                                         self.config['marionette_address']))
> +            if self.config.get('app_arg'):
> +                cmd.extend(self._build_arg('--app-arg', self.config['app_arg']))

_build_arg() handles the case where the value is None, so you can get rid of this if statement and s/config['app_arg']/config.get('app_arg')

Comment 7

[Jonathan Griffin (:jgriffin)]

Comment on attachment 8410579 [details] [diff] [review]
Add --browser-arg support to mochitest/reftest on B2G desktop builds,

Removed the _build_arg() call and landed the mozharness piece:  https://hg.mozilla.org/build/mozharness/rev/77c9ccf077b0

Comment 8

[Jordan Lund (:jlund)]

mozharness patch live in production: http://hg.mozilla.org/build/mozharness/rev/d5a7c46032fe :)

Comment 9

[Jonathan Griffin (:jgriffin)]

https://hg.mozilla.org/integration/b2g-inbound/rev/9c4a9fe63542

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/9c4a9fe63542