999747 - Add --browser-arg support to Gaia unit tests

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[Jonathan Griffin (:jgriffin)]

We want to be able to run "G" tests in TBPL with and without OOP; to do that we'll need to add support for a --browser-arg CLI.

Comment 1

[Jonathan Griffin (:jgriffin)]

Attachment: Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/18549

Comment 2

[Jonathan Griffin (:jgriffin)]

Attachment: Add --browser-arg support to gaia-unit mozharness script,

These options are used by other Gaia tests as well, but --browser-arg will be a no-op there until I update their runners.

Comment 3

[Andrew Halberstadt [:ahal]]

Comment on attachment 8410610 [details] [diff] [review]
Add --browser-arg support to gaia-unit mozharness script,

Review of attachment 8410610 [details] [diff] [review]:
-----------------------------------------------------------------

::: scripts/gaia_unit.py
@@ +41,5 @@
>                                                               'profile-debug')))
>          cmd.extend(self._build_arg('--symbols-path', self.symbols_path))
>  
> +        if self.config.get('browser_arg'):
> +            cmd.extend(self._build_arg('--browser-arg'), self.config['browser_arg'])

nit: these two lines can just be:
cmd.extend(self._build_arg('--browser-arg'), self.config.get('browser_arg'))

Comment 4

[Andrew Halberstadt [:ahal]]

Comment on attachment 8410604 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/18549

Looks good, though I have a suggestion inline with the commit.

Comment 5

[Jonathan Griffin (:jgriffin)]

(In reply to Andrew Halberstadt [:ahal] from comment #4)
> Comment on attachment 8410604 [details] [review]
> Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/18549
> 
> Looks good, though I have a suggestion inline with the commit.

Addressed comments and landed as https://github.com/mozilla-b2g/gaia/commit/5172dc8f50709dbae768f1c44dfeac538e13a1f6

Comment 6

[Jonathan Griffin (:jgriffin)]

(In reply to Andrew Halberstadt [:ahal] from comment #3)
> Comment on attachment 8410610 [details] [diff] [review]
> Add --browser-arg support to gaia-unit mozharness script,
> 
> nit: these two lines can just be:
> cmd.extend(self._build_arg('--browser-arg'), self.config.get('browser_arg'))

Changed, and pushed: https://hg.mozilla.org/build/mozharness/rev/da14cbfcfdab

Comment 7

[Jordan Lund (:jlund)]

mozharness patch is in production: http://hg.mozilla.org/build/mozharness/rev/9accabdd4358 :)