999771 - eyedropper_basic.js leaks windows until shutdown on linux debug when running from a standalone directory

Status: RESOLVED WORKSFORME

(DevTools :: Inspector, defect)

Description

[Joel Maher ( :jmaher ) (UTC -8)]

I am working on bug 992911 where we run each subdirectory by itself, not a bunch of tests as a large chunk.  This yields some new failures, and on linux debug (32|64) dt1, we get a consistent leak failure:
https://tbpl.mozilla.org/?tree=Try&rev=c4f289ae1a05

here is a link to the log file:
https://tbpl.mozilla.org/php/getParsedLog.php?id=38269608&tree=Try

in bug 939040 we seem to have landed this test, it is disabled on windows debug, but the comment in browser.ini doesn't seem to be accurate.

Comment 1

[Joel Maher ( :jmaher ) (UTC -8)]

Patrick- would you have more information on this bug?  I would like to know a bit more about this.

Comment 2

[Patrick Brosset <:pbro>]

The eyedropper tool creates and loads an inner iframe which appears to be leaking here.
The test itself creates 2 instances of EyeDropper (`let dropper = new Eyedropper(window);`) but doesn't seem to destroy them and, the EyeDropper's `destroy` method is supposed to clear the iframe, so perhaps this leak can simply be avoided by calling destroy.

Heather, do you think that could be it?

Comment 3

[Heather Arthur [:harth]]

(In reply to Patrick Brosset [:pbrosset] [:patrick] from comment #2)
> The eyedropper tool creates and loads an inner iframe which appears to be
> leaking here.
> The test itself creates 2 instances of EyeDropper (`let dropper = new
> Eyedropper(window);`) but doesn't seem to destroy them and, the EyeDropper's
> `destroy` method is supposed to clear the iframe, so perhaps this leak can
> simply be avoided by calling destroy.

destroy() is called by the eyedropper itself once you've pressed esc or selected a color from the page, so you won't see it explicitly in the test, but it should be called.

> Heather, do you think that could be it?

I don't know what could be the issue off the top of my head. Maybe the finish() is called before the last eyedropper is destroyed - so the clipboard listener picks up on the copied string before destroy() is called.

One solution is to remove the iframe and build the UI manually, like you were suggesting before. This wouldn't be a super quick fix, but would get rid of this problem for sure.

Comment 4

[Heather Arthur [:harth]]

I'll try to fix the test or at least put some more logging in.

Comment 5

[Joel Maher ( :jmaher ) (UTC -8)]

this doesn't seem to be a problem anymore, we now run devtools with --run-by-dir