999902 - [Flatfish] Failed to build Flatfish, error: 'class android::GonkNativeWindowClient' has no member named 'getIGraphicBufferProducer'

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[Vicamo Yang [:vicamo][:vyang]]

Attachment: err.txt

+++ This bug was initially created as a clone of Bug #911046 +++

media/webrtc/signaling/src/media-conduit/WebrtcOMXH264VideoCodec.cpp: In member function 'android::status_t mozilla::WebrtcOMXDecoder::ConfigureWithParamSets(const android::sp<android::MetaData>&)':
media/webrtc/signaling/src/media-conduit/WebrtcOMXH264VideoCodec.cpp:295:52: error: 'class android::GonkNativeWindowClient' has no member named 'getIGraphicBufferProducer'
media/webrtc/signaling/src/media-conduit/WebrtcOMXH264VideoCodec.cpp: In member function 'webrtc::I420VideoFrame* mozilla::WebrtcOMXDecoder::GenerateVideoFrame(const mozilla::EncodedFrame&, uint32_t, const android::sp<android::ABuffer>&)':
media/webrtc/signaling/src/media-conduit/WebrtcOMXH264VideoCodec.cpp:482:65: error: invalid static_cast from type 'android::RefBase*' to type 'android::GraphicBuffer*'

Comment 1

[John Lin [:jhlin][:jolin]]

Attachment: Enable WebRTC OMX codec only for Android version >= 18.

Comment 2

[John Lin [:jhlin][:jolin]]

Attachment: Enable WebRTC OMX codec only for Android version >= 18. Take 2.

Some partners are still using JB 4.2 (API level 17). Change build config to make sure WebRTC OMX code will not be enabled on those devices.

Comment 3

[John Lin [:jhlin][:jolin]]

Attachment: Enable WebRTC OMX codec only for Android version >= 18.

update commit message & carry r+ from jesup.

Comment 4

[John Lin [:jhlin][:jolin]]

Try result: https://tbpl.mozilla.org/?tree=Try&rev=5a1e333b6ab0

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3dd6d30c3050

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/3dd6d30c3050