Enable replace-malloc on nightly builds

RESOLVED FIXED in mozilla32

Status

()

defect
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: glandium, Assigned: glandium)

Tracking

unspecified
mozilla32
x86_64
Linux
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

No description provided.
Assignee: nobody → mh+mozilla
Status: NEW → ASSIGNED
Comment on attachment 8410749 [details] [diff] [review]
Enable replace-malloc on nightly builds

Looks fine. A comment explaining why we want this on for nightly by default would be nice, though.
Attachment #8410749 - Flags: review?(mshal) → review+
Backed out because of the conflict with trace-malloc on debug builds, and the lack of jemalloc on x86 part on osx universal builds.
https://hg.mozilla.org/integration/mozilla-inbound/rev/bf7655b24009

So this means the dependency on 999869 is backwards.
No longer blocks: 999869
Depends on: 999869
Depends on: 1004359
So, now that tracemalloc is disabled on debug builds, we can actually enable replace malloc without waiting on something else. It would be nice if it worked without jemalloc too, but it's good enough if it covers all platforms except 32-bits osx.
Attachment #8426036 - Flags: review?(mshal)
Attachment #8410749 - Attachment is obsolete: true
No longer depends on: 1004359
No longer depends on: 999869
Attachment #8426036 - Flags: review?(mshal) → review+
Depends on: 1014134
https://hg.mozilla.org/mozilla-central/rev/a9f95997fe57
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
You need to log in before you can comment on or make changes to this bug.