Closed Bug 161365 Opened 22 years ago Closed 22 years ago

Scrollbar arrows highlight when clicked, but scrolling doesn't occur

Categories

(Core :: DOM: UI Events & Focus Handling, defect, P1)

Product:
Core
Component:
DOM: UI Events & Focus Handling
Platform:
PowerPC
macOS
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
mozilla1.2beta

People

(Reporter: tracy, Assigned: mikepinkerton)

References

Details

(Keywords: classic, regression, Whiteboard: helpwanted)

Attachments

(2 files)

notify anyone attribute changed
775 bytes, patch
kinmoz
: review+
sfraser_bugs
: superreview+
Details | Diff | Splinter Review
shot in the dark patch but it would seem to make sense :)
766 bytes, patch
Details | Diff | Splinter Review 
seen on mac commercial trunk build 2002-08-06-10-trunk

-Open browser window (or composer or mail) on a page that has more content than
will fit in the window, thus causing the scroll bars to appear
-attempt to use the < >, for horizontal or vertical scrolling.  

The arow butons do not work.  
However, using the scroll button with manually dragging and/or clicking in the
scroll bar both work as expected.
I don't know how long this has been like this. Jon Dee has been smoketesting mac
osx trunk all summer.  This is the first I've seen this os/tree/build in a while.
To kevin for triage
Assignee: attinasi → kmcclusk
Keywords: regression
*** Bug 162496 has been marked as a duplicate of this bug. ***
*** Bug 162161 has been marked as a duplicate of this bug. ***
bug 162496 comment 0: Works with modern skin from same build.

bug 162496 comment 1: Same on MacOS 9.1 Build 2002080908 I'ts seems to be a
focus problem, when i click some where in the page, it works.
Summary: Scroll < > 's don't work → Scroll < > arrows don't work
*** Bug 162556 has been marked as a duplicate of this bug. ***
this is a dupe of another bug opened last week
*** Bug 162411 has been marked as a duplicate of this bug. ***
Severity: major → critical
Keywords: nsbeta1
Sounds like a focus issue: Based on comment #5
Assignee: kmcclusk → saari
Component: Layout → Event Handling
Using Build 2002081703 and Classic theme, I cannot get scrollbar arrows to work,
no matter how much I click on the page.  Clicking on page is sometimes needed to
get arrow keys to work for scrolling.  Scrollbars have always worked before even
without focus.

Also, holding down button on scroll bar arrow causes CPU load to hit 100%. 
Something's spinning...


Not to mention that they also don't work for form textfield elements, either.
In build 2002082109 this bug is only in the classic theme, the scroll arrows
work in the modern theme.
In build 2002-08-21-09 the scroll arrows do NOT work in the Navzilla theme.

i get a css error on the console in a debug build. something about an invalid |
prefix.
Same problem with the Pinstripe Theme.
*** Bug 163324 has been marked as a duplicate of this bug. ***
WFM Mozilla 1.1 release, Modern/Classic/Navzilla.

> WFM Mozilla 1.1 release, Modern/Classic/Navzilla.

That's the branch build. The problem is on the trunk.
From http://www.mozilla.org/

"Mozilla 1.1
This is our latest bleeding edge release which contains all the changes that
happened on the trunk since we branched for Mozilla 1.0."

What is a branch build if not a reflection of what has taken place on the trunk?
How old is this "release" version of Mozilla 1.1 then? Is there a FAQ explaining
in detail "trunk" and "branch" for us mortal (l)users?

Niklas, see http://www.mozilla.org/roadmap.html#tree-management - 1.0 branched
2002-04-09, 1.1 branched 2002-08-02 (before this bug appeared, apparently).
IIRC, I've seen CSS errors relating to scrollbars at startup. That could be related.
I downloaded and installed Build ID: 2002082808 only to find that the verticle
scroll arrows no longer initiate scrolling in either direction.  They do
highlight when selected; but, no scrolling takes place.  The ability to intiate
scrolling via moving the cursor in or around the highlighted control area is
also no longer
present. The version is running under MacOS 10.1.5.  What changed?


Adding classic keyword per comment 5.
Keywords: classic
*** Bug 165930 has been marked as a duplicate of this bug. ***
Comment 14 and comment 21 both seem to point fingers at CSS errors.
Blocks: 1.2a
This seems to be fixed in the Mozilla 1.1 release version. At least the
Pinstripe skin's arrows are working again.
Not fixed for me (Classic theme, Mac OS 9.1, Build 2002083017)
I still have to click in the page.

The focus problem seems to depend on the visited page. Some pages works, other not.
They are always the same.

I found also another thing with http://www.mozilla.org/
It always works, except when i use the Mozilla icon to go to this page.
I have tried Personal toolbar, menu bookmarks, typing the url, all works 
 Any Idea ?
This is the Mac build, not the OS X build?

As of 8/31, and as far back as 8/8, the Mac OS X Fizilla mach-o build (I build
them myself) has seen similar problems. It looks like a XUL problem.

In Modern skin, there's no problems.

In Classic skin, the arrows on the keyboard work. Clicking on the scroll area
works. Dragging the scroll thumb works. But the arrow buttons (on the top or
bottom of the scroll area) don't work. Nothing happens. The arrow buttons on
form elements, like this text field, do work, in Modern or Classic, but not for
the main browser window in Classic.

I guess I'll be living in Modern until I learn enough XUL to hack the Classic
theme to get the scroll buttons to work, or there is a fix.
I post a solution. See bug 145933 #5.
Bruno
Classic skin CSS issues, -> andreww
Assignee: saari → andreww
*** Bug 145933 has been marked as a duplicate of this bug. ***
unable to reproduce with 0904 OS X build.
No longer blocks: 1.2a
Mac OS 9.1 Build 2002090309
1)
The comment comment 28 about www.mozilla.org and the mozilla icon is still valid
2)
I have also noticed that:
- Click in the Location Field
- Click On Home (My home page is a local file)
- Use the up or down  arrow
  The focus is still in the location, and a menu "Search goocle for ... is opened"

- Click in the Location field
- Click on some other link in the personnal tool bar (ie:Latest Builds)
- Use the up or down arrow.  There is no menu, and the page scrolls
Why this difference ?
I am not sure that it is the same problem that this bug

3) http://www.frtracker.com/
I can't use the arrows with this site. I have to click in the page.
If i don't click, sometime i have the Location Menu opend as in 2)
, sometimes nothing happens. More curious with this site:
-I click on the page
-I use the arrow keys (The page scrolls)
-i Click on Reload
-I use the arrow keys (no scroll)




Please set the OS to ALL

Re comment 33: I *still* see the bug with 0904 OS X builds here.

Both the CFM and Mach-O trunk builds (2002090413, resp. 2002090407) exhibit it,
under OS X 10.1.5 with classic theme. For me it affects all web pages, as well
as in MailNews, the message pane (but not the other 2 panes). None of the
suggested workarounds, such as clicking in the page or creating a new profile
(comment 30), seem to help. Clicking arrows has no effect other than max out the
CPU usage.

Changing OS to 9.x as per comments 27 and 35.
OS: MacOS X → Mac System 9.x
*** Bug 166961 has been marked as a duplicate of this bug. ***
*** Bug 167347 has been marked as a duplicate of this bug. ***
Please Set Os to ALL.
Dups  Bug 166961 and Bug 167347 are about OSX

Jean-Pierre: `OS: All' would include Linux and OpenBSD, which run on the Mac
platform but aren't known to be affected.

(It would be nice to have an `All Mac OSes' category for such cases, which
happen all the time.)
*** Bug 167345 has been marked as a duplicate of this bug. ***
This bug has been treated as both OS9 and OSX problem, but it was originally
reported for OSX.
This fact is sufficient to mark the OS for this bug as All.
OS: Mac System 9.x → All
*** Bug 167488 has been marked as a duplicate of this bug. ***
Looking into this today.
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla1.2beta
for comment 40
this rule is not a general rule. See bug  161365 comment 42.

I don't say i don't agree. But is there a way to use the same rule for every body 
? 

I'm able to replicate the problem on my debug build. I'm trying out various 
ideas now. If anyone has suggestions, please post them..

Ok now after commenting out the wierd style rules  in nativescrollbars.css 
things started working again. But after undoing this to make sure, I'm no 
longer able to see the scrolling problem.  

BTW scrolling on macosx is bad - I get painful redraws, flickering, etc.   

If anyone has a firm test case to replicate the scrolling issue, please note 
it here. I tried the clicking on the throbber to load a page w/o focus, but  I'm 
still able to use the scroll arrows now.

I saw another js error that said "unable to parse value 'height'" in global/
scrollbars.css 

*** Bug 167943 has been marked as a duplicate of this bug. ***
*** Bug 168114 has been marked as a duplicate of this bug. ***
hirata, please see comment 40 as to why this is not Mac/All. Setting it Mac
System 9.x means it covers 9.x and later, including OS X.
OS: All → Mac System 9.x
Mozilla 1.2a on Mac OS X has shipped with broken scrollbar arrows. Hoooray!!!
Guess I'll be downgrading back to 1.1.
Greg--I don't think that the majority of Mac-specific bugs are categorized as
you say.  Setting the OS to 9.x means the bug is only on 9.x (and may get a
lower priority than a bug which is present on All Mac OS).  I don't think I've
seen a bug yet that has been only Macintosh Platform and All OS (including
BSD/Linux) and not been for All platforms (most bugs tend to be All platforms is
they are broken on Linux).  I would prefer that we not make the distinction of
All Macintosh including BSD and Linux.  It is far more useful to triage Mac bugs
with OS:All or OS:OSX or OS:OS9 than trying to determine if the bug is just OS9
or OSX too.
I really want to fix this, but I need a reproducable test case. I saw it on my 
debug machine 1 time, but now I'm unable to get the problem to 
reproduce. If you know of a way to get the arrows to stop working please 
post those steps here!

Changing OS to OSX - please dont fiddle with the OS setting - os9 's time 
is waning and OSX is growing - and so the focus here needs to be on the 
OSX versions.
OS: Mac System 9.x → MacOS X
Priority: -- → P1
Whiteboard: helpwanted
*** Bug 168177 has been marked as a duplicate of this bug. ***
It's reproducible always for me. That doesn't help you much - but it's also
reproducible always from PPEmbed (part of normal Mac mozilla build, run from
same viewer_debug as mozilla)
I wonder if ppembed shows it if you hack installed-chrome.txt to use modern skin.
> I wonder if ppembed shows it if you hack installed-chrome.txt to use modern skin.

It doesn't - modern is fine. Actually, you don't have to hack
installed-chrome.txt if it's running from the same dir as mozilla - just replace
PPEmbed's <profile>chrome/chrome.rdf with one from a mozilla profile which is
set to modern.
In response to comment 54, it's always reproducible for me.  All I have to do is
download any of the recent nightly trunk builds -- the scroll arrows don't work.
 I am using the classic theme.
*** Bug 168253 has been marked as a duplicate of this bug. ***
*** Bug 168313 has been marked as a duplicate of this bug. ***
*** Bug 168399 has been marked as a duplicate of this bug. ***
In response to
<url="http://bugzilla.mozilla.org/show_bug.cgi?id=161365#c54">comment 54,</url>
The second part of the bug's description hit's the nail on the head, "The
[scroll] arrow butons do not work.  However, using the scroll button with
manually dragging and/or clicking in the scroll bar both work as expected."  In
my case I downloaded 1.2b for Mac OSX and updated 1.1a ovver it and had all four
arrows (right, left, up and down) not work and continue not to work for any site
I go to.  I tried the trash all Mozilla files and reinstalling 1.2b but the
issue still arises.  The case wasn't there in 1.1alpha.
*** Bug 168630 has been marked as a duplicate of this bug. ***
*** Bug 168650 has been marked as a duplicate of this bug. ***
andreww, re: comment 54, are you saying scroll arrows work for you using the
classic theme? (You are using classic, right? They work in Modern.)

As for the OS setting, until OS 9 support is really stopped, that's how these
bugs should be marked. It's your bug, though, and you can fiddle with it how you
want.
1.1 in classic, the arrows all work.
1.2a in classic, the arrows do not work.
1.2a in modern, the arrows all work.

I did not test modern under 1.1.
Oh yeah, the above happens on two computers running Jaguar (10.2), one being a
beige G3, and the other a TiBook 667.

I do not have any computers running 10.1.x to see if that makes a difference.
I was able to repro this on a trunk mac OS X build, but not a trunk mac os 9
build (classic skin  both times).
Using Mac OS X.1.5 I can only use the scroll buttons when I am in the modern
theme. They do not work under either Pinstripe or Classic. 
When every body says "don't work", this means that the arrows don't work att all, 
or it it is simply my focus problem. Clicking on the page resolve the problem ?

In my case.. "Don't Work" means:

The Control Arrow hilites when I click in it and de - hilites when I release the
mouse button. However it does not Scroll the page up or down in long multipage
web sites like it's supposed to. That's what i mean by broken.
Summary: Scroll < > arrows don't work → Scrollbar arrows highlight when clicked, but scrolling doesn't occur
I haven't seen any mention of the fact that the "sidebar" scrollbar arrows
within the Browser work as desired. Obviously not shared scrolling code.  
  
Scrolling in trees like the prefs category tree, mail threads, bookmarks sidebar
panel, etc. do seem to work but not in an area of content (ie. browser, mail
message pane, the tinderbox sidebar panel). Tested with 9/14 build.
In my original report I mentionned that the side bar scrolled. But I also
reported that ever since 10.2 Apple's  page wasn't available anymore except the
bottom part of it while it came up immediately with explorer. No one seems to be
taking care of that part.
Finally start seeing this behavior in a repeatable way:
launch browser, (my home page is google so no scrolling), 
goto www.scripting.com ,
try to scroll  by clicking on arrows - nothing happens. 
Finally I can start to narrow down the problem. Working on this now.
There is something wrong going on in the binding to xul:nativescrollbar ... 
when I change the binding from : 

-moz-binding: url(chrome://global/content/bindings/
nativescrollbar.xml#scrollbar);

to 

-moz-binding: url(chrome://global/content/bindings/
scrollbar.xml#scrollbar);

I get a gray bar with no images, but the clickable regions (top, bottom 
arrows, slider, slider tray) work perfectly and get the correct mouse 
events.  This explains why modern is working ok, since it's not using 
native scrollbar code in it's binding, but the xul-defined one instead.

this binding:

-moz-binding: url(chrome://global/content/bindings/
nativescrollbar.xml#scrollbar);


points to xbl which reads: 


  <binding id="scrollbar">
    <content>
      <xul:nativescrollbar flex="1" xbl:inherits=
"curpos,maxpos,pageincrement,increment,orient,sborient=orient"/>
    </content>
  </binding>


 I cannot find any further bindings to this xul:nativescrollbar element- so it 
must be some internally defined atomic element.  So whatever's 
happened to mac scrollbars has gone wrong somewhere in the code to 
display this nativescrollbar element.



Looking at the css in the Pinstripe theme, I see  that it also refers to this 
nativescrollbar (cloned from classic - no doubt).

Given that I believe this is not caused by a css bug in classic specifically, 
but instead something in the mac nativescrollbar implementation, I'm 
sending this to Pinkerton to see if there's something he might know since 
I see he's in CVS having  implemented  the mac nativscrollbar code.

--> Pink
Assignee: andreww → pinkerton
Status: ASSIGNED → NEW
*** Bug 168899 has been marked as a duplicate of this bug. ***
Isn't this a dup of bug 161365?
I reported this bug when it repeated after intalling X.2 Previous to OS update
Mozilla worked bormally.


Incidentally, now when clicking the URL in the email I am responding to I do not
get this page if Mozilla isn't up. Starting Mozilla it works again.
> Isn't this a dup of bug 161365?

This is bug 161365. I was thrown off by the summary change too - thought I had a
case of deja vu. Can people stop tweaking the fields of this bug?
*** Bug 168995 has been marked as a duplicate of this bug. ***
This is my first experience on Bugzilla so I'm sorry I duplicate existing bug. 
I am also a ham-fisted Silver Surfer and most of what is written loses me but
oen thing stands out.  There seems to be a lot of chat but very little
resolution.  When does the action happen to sure the problem?
There is a weird scroll bug which is also specific to Classic theme (bug 163788).
*** Bug 169147 has been marked as a duplicate of this bug. ***
*** Bug 169471 has been marked as a duplicate of this bug. ***
here's the problem: 

in nsGFXScrollFrame, we set several attributes on the scrollbox (maxpos,
pageincrement, increment, etc). Everything gets through to the native scroll
frame _except_ for increment, which for some unknown reason gets dropped on the
floor and thus remains at 0. 

Anyone know why this would have changed and why it works on the branch but not
the trunk? I couldn't see any changes to the css or the xbl. The native scroll
frame is functioning correctly except for this mysterious missing
attribute-changed event.

cc'ing dbaron and kin, per brendan's request.
Status: NEW → ASSIGNED
more dirt...

the relevant attribute setting code is this block in nsGFXScrollFrame:

  if (mHasVerticalScrollbar && mVScrollbarBox) {
    SetAttribute(mVScrollbarBox, nsXULAtoms::maxpos, maxY);
    SetAttribute(mVScrollbarBox, nsXULAtoms::pageincrement,
nscoord(scrollAreaRect.height - fontHeight));
    SetAttribute(mVScrollbarBox, nsXULAtoms::increment, fontHeight, PR_FALSE);
  }

if i change the last line to:

  SetAttribute(mVScrollbarBox, nsXULAtoms::increment, fontHeight);

it _works_! But yet it also works on the branch with that last param as
PR_FALSE. Can anyone explain that!?
The change between branch and trunk could be bug 156547 (I think the change that
I did check in for that bug so far is correct).  If that's the case, then if you
need an AttributeChanged notification, it seems like a bad idea to pass PR_FALSE
for the aNotify parameter (although perhaps the aNotify parameter could vary
depending on whether it's needed).
dbaron, so it looks like you made it actually start respecting that notify
param, which would explain why it suddenly stopped working (obviously FALSE
would cause it to not get sent). Ok, then i guess the patch is really that
simple, just remove the last PR_FALSE param on the SetAttribute() call.

who owns nsGFXScrollFrame these days? would they mind me touching it?
Attached patch notify anyone attribute changed — — Splinter Review 
simple patch. needs r/sr
Comment on attachment 99738 [details] [diff] [review]
notify anyone attribute changed

r=kin@netscape.com
Attachment #99738 - Flags: review+
Comment on attachment 99738 [details] [diff] [review]
notify anyone attribute changed

sr=sfraser
Attachment #99738 - Flags: superreview+
Comment on attachment 99738 [details] [diff] [review]
notify anyone attribute changed

r=bryner
fixed.
Status: ASSIGNED → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
Pinkerton - awesome job! Thanks!
*** Bug 169527 has been marked as a duplicate of this bug. ***
I am proposing this bug be reopened. Horizontal scrollbars are broken using the
trunk build (September 19) build id 2002091908.

Steps to reproduce:
1.Go to any page that creates a horizontal scrollbar such as www.netscape.com
(Resize the window until scrollbars appear.)
2. Try to use the scrollbar at the bottom of the page, the arrows highlight but
will not scroll sideways.

I am using OS X 1.5 with the Classic Theme.
I reported that the bottom arrows do not work when I first reported this bug. In
addition I reported
two more bugs:
1) Mozilla doesn't access Apple webpage anymore except for the bottom of the page.

2) Clicking on http://bugzilla.mozilla.org/show_bug.cgi?id=161365
 doesn't bring Mozilla if Mozilla isn't on. It shows the first screen of Mozilla
briefly only. A Mozilla that is already on will bring the page up.
Albert, those are separate problems. Please report them as separate bugs, or
reopen your original bug if it was incorrectly marked a duplicate of this one.
Reopening per comment #99 .
Horizonal scroll still needs the fix.
2002091908 trunk build.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
yeah, forgot that, sorry. fixed.
Status: REOPENED → RESOLVED
Closed: 22 years ago → 22 years ago
Resolution: --- → FIXED
Horizontal and vertical scroll arrows fixed as seen on mac osx commercial trunk
build 2002-09-20-03-trunk

marking verified
Status: RESOLVED → VERIFIED
my bad......horizontal scroll arrows are still broken.  However, the vertical
scroll arrows work.  This bug was originally filed against both orientations
scroll arrows not functioning.  Can whatever was done to fix the vertical scroll
be applied to horizontal?

reopening.  Sorry for the confusion.
Status: VERIFIED → REOPENED
Resolution: FIXED → ---
sigh. i did that this morning. fixed.
Status: REOPENED → RESOLVED
Closed: 22 years ago → 22 years ago
Resolution: --- → FIXED
Scrollbar arrows are working for me now in this morning's nightly--2002092308.
Job well done.
Arrows are working as they should from the nightly repaired.

Links in email still do not work if Mozilla isn't active.
Apple's address doesn't work in Mozilla but works in Explorer. I reported those
two before
*** Bug 170338 has been marked as a duplicate of this bug. ***
*** Bug 170373 has been marked as a duplicate of this bug. ***
Albert, those other two problems have nothing to do with this bug.
*** Bug 170650 has been marked as a duplicate of this bug. ***
*** Bug 170711 has been marked as a duplicate of this bug. ***
*** Bug 170857 has been marked as a duplicate of this bug. ***
*** Bug 170860 has been marked as a duplicate of this bug. ***
*** Bug 170955 has been marked as a duplicate of this bug. ***
*** Bug 170897 has been marked as a duplicate of this bug. ***
Verified.
Status: RESOLVED → VERIFIED
*** Bug 171288 has been marked as a duplicate of this bug. ***
*** Bug 171401 has been marked as a duplicate of this bug. ***
*** Bug 171517 has been marked as a duplicate of this bug. ***
*** Bug 171691 has been marked as a duplicate of this bug. ***
*** Bug 171757 has been marked as a duplicate of this bug. ***
Has anyone else experienced a problem with navigation within a page with not
being able to move within a field with the keyboard arrow keys?  I visited pages
that using any of the arrow keys doesn't work or where just the right arrow key
doesn't work.
*** Bug 171783 has been marked as a duplicate of this bug. ***
Joe, you should ask about that in a newsgroup, or file a separate bug.
I'm sorry I posted a duplicate bug! please stop bombading me with messages 
telling me so. One or two would have been sufficient. 

I'm sorry I don't have all day to comb through bug reports to make sure I post a 
new one. I'll stop being so stupid and just not post bugs anymore or maybe stop 
using Mozilla all together until a more ready for primetime version becomes 
available. 

Please take me off whatever list I'm on having to do with mozilla bug reports.

Thanks,

Alan

Alan, you're not on a "list". To stop receiving e-mails about this bug, remove
yourself from its' cc: list.
*** Bug 171825 has been marked as a duplicate of this bug. ***
*** Bug 172048 has been marked as a duplicate of this bug. ***
Is it possible to check this in and rebuild 1.2a release?
This dupe keeps coming up so many times because of 1.2a release build.
It wouldn't be worth it, hirata. People would still have to re-download it, and
1.2 beta is coming up in a week or two, anyway.

Let's leave it simply resolved, not verified, though, so it shows up on
duplicates.cgi.
Status: VERIFIED → REOPENED
Resolution: FIXED → ---
Re-resolving Fixed. Please refrain from Verifying until 1.2 beta is released.
Status: REOPENED → RESOLVED
Closed: 22 years ago → 22 years ago
Resolution: --- → FIXED
scrolling DOES work in MODERN theme but NOT in CLASSIC or PINSTRIPT theme!!!!
*** Bug 172417 has been marked as a duplicate of this bug. ***
 i just verified that scroll arrows do work under modern theme, but the mail msg
window only has single arrows @ top & bottom, although all other scrolled
windows have paired arrows top & bottom (i have set w/ tinkertool) 
*** Bug 172828 has been marked as a duplicate of this bug. ***
*** Bug 173732 has been marked as a duplicate of this bug. ***
*** Bug 173768 has been marked as a duplicate of this bug. ***
*** Bug 174100 has been marked as a duplicate of this bug. ***
*** Bug 174078 has been marked as a duplicate of this bug. ***
*** Bug 174596 has been marked as a duplicate of this bug. ***
*** Bug 174748 has been marked as a duplicate of this bug. ***
*** Bug 175577 has been marked as a duplicate of this bug. ***
Re-marking Verified per comment 134 as Mozilla 1.2 has shipped.
Status: RESOLVED → VERIFIED
Component: Event Handling → User events and focus handling
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: