180659 - No way to zoom Mozilla help content

Status: VERIFIED FIXED

(SeaMonkey :: Help Documentation, enhancement)

Description

[Max Alekseyev]

Open Help->Help Contents and try to zoom the text. Neithert pop-up context menu
offer such feature, nor Ctrl++ work.

By default, here the very small font is used to display the help. Hence, the
help is unreadable.

Comment 1

[Boris Zbarsky [:bzbarsky]]

To help component, and yes that is very hard to read.  It's about 2/3 the size
of my menu font at best....

Comment 2

[Brant Gurganus]

accessibility issue

Comment 3

[Max Alekseyev]

There is a workaround: http://bugzilla.mozilla.org/show_bug.cgi?id=177510#c7

Comment 4

[Ian Oeschger (gone)]

moving stuff over to an outside-the-firewall email for the time being, looking
for people to pick these Help and doc bugs up for me.

Comment 5

[R.J. Keller]

--> me

This will be in the 1.6a Firebird/Thunderbird help menu.

Comment 6

[R.J. Keller]

Fixed this in the 1.6a Firebird/Thunderbird help that's in development. You
won't see this until the new help menu is checked in.

Comment 7

[R.J. Keller]

Accepting.

A minimum of Ctrl+/Ctrl- will be in for 1.6

Comment 8

[R.J. Keller]

Attachment: Patch

Adds Ctrl+ and Ctrl- to help

Comment 9

[R.J. Keller]

Comment on attachment 131365 [details] [diff] [review]
Patch

timeless, jag said that you are a person who can review help code, so could you
review this for me?

Comment 10

[[e-mail]]

Comment on attachment 131365 [details] [diff] [review]
Patch

Sorry, but viewZoomOverlay seems to need menu_textZoom - perhaps you could add
it to the context menu?

Comment 11

[R.J. Keller]

Are you sure of this? I have used Help with this patch for some time without any
problems (no JS errors). Is it required that you use everything that the overlay
overlays?

Comment 12

[R.J. Keller]

If you want it to be added to the context menu, then we'll probably have to wait
for bug 214678.

Comment 13

[R.J. Keller]

Attachment: Patch with the Zoom Menu added to right-click menu.

Wow! Just built with the patch and this is pretty sweet! It'll be nice to have
this in!

Comment 14

[[e-mail]]

Comment on attachment 133527 [details] [diff] [review]
Patch with the Zoom Menu added to right-click menu.

r=me if you fix these nits:

>+  <commandset id="viewZoomCommands"/>
>   <commandset id="clipboardEditMenuItems"/>
>   <commandset id="viewZoomCommands"/>
Don't need this twice...

>+  <keyset id="viewZoomKeys"/>
This turns out to be a duplicate too...

>+  <stringbundleset id="stringbundleset">
>+    <stringbundle id="bundle_viewZoom"/>
>+  </stringbundleset>
Either drop the stringbundleset, or put all the other stringbundles in too.

Comment 15

[[e-mail]]

Comment on attachment 133527 [details] [diff] [review]
Patch with the Zoom Menu added to right-click menu.

>   <stringbundle id="bundle_viewZoom"/>
>   <stringbundle id="findBundle" src="chrome://global/locale/finddialog.properties"/>
>+  <stringbundleset id="stringbundleset">
>+    <stringbundle id="bundle_viewZoom"/>
>+  </stringbundleset>
Oops, another duplicate, I must have deleted the first line for my previous
review by mistake :-/

Comment 16

[R.J. Keller]

Attachment: Patch stripped down.

Not sure why those <command>s are there. I guess IO left them there by accident
(I've noticed this with other <command>s).

Comment 17

[Alec Flett]

Comment on attachment 133530 [details] [diff] [review]
Patch stripped down.

sr=alecf

Comment 18

[R.J. Keller]

Fix checked in!

Comment 19

[Daniel Wang]

v