223287 - Cannot manually edit home page in Preferences if toolbar icon is removed

Status: RESOLVED FIXED

(Firefox :: Settings UI, defect)

Description

[Will Rickards]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.5) Gecko/20031007 Firebird/0.7
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.5) Gecko/20031007 Firebird/0.7

When first installed it works fine.  Once you customize the navigation bar as
detailed in steps to reproduce, the OK button of the preferences dialog does not
work.  It does not save the changes or close the dialog.

Reproducible: Always

Steps to Reproduce:
a. Delete firebird directory and profile directories (Mozilla, Phonenix) in
Application Data.
1. Install Firebird by extracting to "C:\Program Files\mozilla.org"
2. Start Firebird Profile Manager by running "C:\Program
Files\mozilla.org\MozillaFirebird\MozillaFirebird.exe" -p
3. Create profile called 'Will'
4. Start Firebird
5. Open preferences dialog and change homepage to verify OK button works at this
point.
5. Right click on navigation bar and click customize.
6. Drag home page icon off bar to icon palette.
7. Click Done on icon palette
8. Open preferences dialog and change homepage.
9. Click OK Button - it doesn't work.
Actual Results:  
OK button does not save changes or close dialog

Expected Results:  
OK button should have saved changes and closed dialog

You can close the browser and come back in but it is still broken.  I haven't
tested other customizations to see if they cause the same problem.  I normally
run without navigation bar or bookmarks bar and have everything in top toolbar.
 I noticed the problem and reduced it to these steps from a 'clean' install.

Comment 1

[Will Rickards]

Also tried it with:
Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.6a) Gecko/20031021
Firebird/0.7+

And it exhibits the same behaviour.

Comment 2

[Mike Connor [:mconnor]]

Firebird != Seamonkey, don't mix tracker bugs please.

I think I know what's causing this actually, but I'm going to dig a little
before I confirm or dupe this.  It does work when clicking to use current
page/use blank page or whatnot.

-> tweak summary to reflect exact problem.

cc-ing noririty, I think this is Blake's checkin for the tooltip issue (bug
184801) from a couple months back, based on what works and what doesn't.  Thoughts?

Comment 3

[Will Rickards]

Related to bug #219368 ?
Any progress on the bug?
Was it the checkin?

Comment 4

[PikeUK]

I think this can be fixed by either changing this line in onOK() in
pref-navigator.js:

domWin.document.getElementById("home-button").setAttribute("tooltiptext",
parent.homepage);

to something like this:

var homeButton = domWin.document.getElementById("home-button");
if (homeButton) homeButton.setAttribute("tooltiptext", parent.homepage);

or just wrap the line in a try/catch. I don't know which is best (sorry, I'm
totally clueless when it comes to best coding style and stuff like that).

Comment 5

[Will Rickards]

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.6b) Gecko/20031208
Firebird/0.7+

Bug still occurs using original steps to reproduce.

Comment 6

[PikeUK]

Attachment: Patch: Fix as described in comment 4

Comment 7

[alanjstr]

per ben on IRC

Comment 8

[Toby Johnson]

*** Bug 233796 has been marked as a duplicate of this bug. ***

Comment 9

[José Jeria]

*** Bug 235985 has been marked as a duplicate of this bug. ***

Comment 10

[Jerry Baker]

Not only does this patch work, but it is still current. Can someone apply this
to the trunk please?

Comment 11

[Mike Connor [:mconnor]]

Comment on attachment 137320 [details] [diff] [review]
Patch: Fix as described in comment 4

pch, this is good and trivial, more good work from Pike!  if you r+ it, I'll
land it today

Comment 12

[Pierre Chanial]

this patch is good, but it's better to provide more context to ease the review.
(cvs diff -u10)

Comment 13

[Mike Connor [:mconnor]]

fix checked in 02/29/2004 10:37

Comment 14

[Dan M]

*** Bug 217055 has been marked as a duplicate of this bug. ***

Comment 15

[Mike Connor [:mconnor]]

sorry for bugspam, long-overdue mass reassign of ancient QA contact bugs,
filter on "beltznerLovesGoats" to get rid of this mass change