246417 - Statusbar/Advanced Options software updater fails even if extension update exists

Status: RESOLVED FIXED

(Toolkit :: Application Update, defect, P2)

Description

[PikeUK]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7) Gecko/20040611 Firefox/0.8.0+
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7) Gecko/20040611 Firefox/0.8.0+

When double-clicking on the update section in the status bar, Firefox always
gives the message "Firefox encountered problems when trying to find updates for
some items", clicking the details button lists all extensions. This happens
regardless of whether an update actually exisits. However selecting an extension
in the Extension Manager and pressing Update will successfully find an update
(assuming one is available).

Reproducible: Always
Steps to Reproduce:
1. Install the extension at the URL (or another one with an update available).
2. Double-click the update area in the status bar.
Actual Results:  
Firefox reports "Firefox encountered problems when trying to find updates for
some items" and lists all extensions in the details box (including those with
updates available).

Expected Results:  
Firefox should have listed the available updates.

According to Ethereal, Firefox successfully fetches the extension's update file
(http://www.pikey.me.uk/mozilla/test/updatetest.rdf) and attempts to fetch
http://update.mozilla.org/update.rdf (which 404s).

Not sure if this is covered by Bug 245953 so I filed a separate bug.

Comment 1

[PikeUK]

Attachment: Extension at v0.1 pointing to update file returning v0.2

Comment 2

[PikeUK]

I'm not sure if this is really a blocker it's a well hidden feature but it'd be
nice if it worked in 0.9.

blocking0.9?

Comment 3

[PikeUK]

(In reply to comment #2)
> I'm not sure if this is really a blocker it's a well hidden feature but it'd be
> nice if it worked in 0.9.

Actually it's not that hidden after all since it's now showing the number 1 in
that statusbar box, and clicking it still doesn't work. Though users can still
get the update via the EM so it's not a total loss.

Comment 4

[PikeUK]

Nope, missed it, blocking1.0?

Comment 5

[PikeUK]

*** Bug 247399 has been marked as a duplicate of this bug. ***

Comment 6

[Ben Goodger (use ben at mozilla dot org for email)]

Attachment: patch

This shows more details about the failed error in the errors dialog

Comment 7

[Ben Goodger (use ben at mozilla dot org for email)]

Now, you either were encountering a bug I fixed as part of the "update works
poorly" bug, or you deliberately made the update RDF file 404

either way, with this patch (shows more information about the failure) and the
patches in the other bug, this bug is fixed, br & trunk.

Comment 8

[PikeUK]

It's now showing updates correctly, but the error window appears broken, the
following message appears whenever it is opened:

Error: uncaught exception: [Exception... "Component returned failure code:
0x80004005 (NS_ERROR_FAILURE) [nsIStringBundle.GetStringFromName]"  nsresult:
"0x80004005 (NS_ERROR_FAILURE)"  location: "JS frame :: XStringBundle ::
getString :: line 16"  data: no]

In addition (and possibly related) the update still fails if you press Update in
the Extensions manager when no extensions are highlighted (not sure if it's even
supposed to work, but it doesn't get greyed out).

Comment 9

[Steffen Wilberg]

But _this_ bug is more or less fixed, isn't it? The testcase works fine now.
I filed bug 251017 about the broken error dialog, with additional info.

Comment 10

[Steffen Wilberg]

Marking as fixed again.

Comment 11

[Ryan Polk (Quark)]

setting fixed-aviary1.0 for bugfixes checked into branch, for searching purposes.
sorry for bugspam.