99102 - update skin versions in all contents.rdf

Status: VERIFIED FIXED

(SeaMonkey :: Themes, defect)

Description

[Joe Hewitt (gone)]

We need to update the skinVersion for all contents.rdf files so old skins won't
try to install on 0.9.4-based builds.

Comment 1

[Joe Hewitt (gone)]

Attachment: patch

Comment 2

[Blake Ross]

sr=blake

Comment 3

[Joe Hewitt (gone)]

hyatt sez r=hyatt

Comment 4

[grega]

This is not important to enterprise customers as most will not be
switching/installing skins.  Can it wait until 0.9.5?  What needs to be tested
if we accept this change?  Thanks!

Comment 5

[Joe Hewitt (gone)]

If an enterprise customer were to attempt to install a new theme from the theme
park (which is conveniently linked to from the Navigator Themes menu), they
would find that the skin makes the product pretty-much non-functional.  This
patch prevents that from happening.

We would need to test switching from one theme to another, especially an
installed theme such as Toy Factory.

Comment 6

[selmer (gone)]

Greg, this is not *only* an enterprise release.

Joe, is it really the case that the product becomes unusable?  If so, that is a
serious problem that needs to be fixed.

The patch itself looks pretty straightforward, but the implications need to be
tested.  Can we get a round of QA against the relevant features in short order?

I think this bug should be nsbranch+.

Comment 7

[Joe Hewitt (gone)]

Yes, installing an old skin on a 0.9.4 build results in a very scrambled,
disfigured UI.  It is still "usable" but there may be some functionality that is
not.

On the bright side, the Netscape Theme Park does sniff for browser versions, and
would not serve old themes to 0.9.4 based browsers, however, other Theme sites
may not be so smart.

Comment 8

[[e-mail]]

What happens when you upgrade and your existing skin is the wrong version?

Comment 9

[Marek Z. Jeziorek]

nsbranch+ per pdt triage

Comment 10

[Joe Hewitt (gone)]

fixed on branch and trunk

Comment 11

[Jaime Rodriguez, Jr.]

Got get the r= and sr= ASAP.

Comment 12

[Joe Hewitt (gone)]

fixed

Comment 13

[Daniel Veditz [:dveditz]]

To answer Neil, if you upgrade and your theme is the wrong version what's
supposed to happen is that the Chrome Registry fails over to the globally
installed default skin (Classic in Mozilla, Modern in Netscape6). Because this
was installed with the product it should by definition be the correct version.

Dunno if Hyatt ever implemented this, but that was the plan.

Comment 14

[David Hyatt]

Yes, that has been implemented.

Comment 15

[R.K.Aa.]

bug 100786 seems to be a case where an existing theme of wrong version is NOT
given the deafult skin instead.

I tried installing the aqua theme on a current CVS build, linux, and it didn't
really install even if it downloaded and managed to trash the content of the
Edit menu before i restarted moz. After restart moz i still had modern skin,
fully functional again, and Aqua didn't list under themes in prefs.

Otherwise, there was no indication during install that this wouldn't work.
I assume bug 100786 is invalid, but it doesn't seem to fail as intended.

Comment 16

[Patty Mac]

Verified on the (branch build: 2001-10-01-05-0.9.4)

Comment 17

[Patty Mac]

Verified