I think the way to push this patch forward is to figure out exactly what kind of sizing behaviour the <deck> usages need: Children with all the same height/usage doesn't care about the height too much: * ~~places.xhtml (#placesViewDeck & #detailsDeck)~~: removed in bug 1678523 * ~~old about:addons~~: removed in bug 1674890 * old perf panel: should be removed in bug 1668219 * old about:config : should be removed in bug 1524836 * #modeDeck (dialog asking you to save or open directly): both children (menulist & button) have 30px height. * .wizard-next-deck: both children are fixed-height buttons * .wizard-page-box: not sure what happens with long content, but https://searchfox.org/mozilla-central/source/toolkit/content/xul.css#544 Follows the biggest child's height (default deck behaviour): * #updateDeck (both about dialog & preferences) * #mainDeck (pageInfo window): need to re-check, but this was causing problems with lots of <meta> tags * #setDefaultPane (preferences): probably doesn't matter too much, but the one of the children is *slightly* bigger due to having the "Make default" button. Only takes the selected child height: * #PanelUI-remotetabs-deck: https://searchfox.org/mozilla-central/rev/2efcda6dc74c63863fd8f04a6d9d7ac6b09c7eca/browser/themes/shared/customizableui/panelUI.inc.css#998 * #historyPane (preferences): https://searchfox.org/mozilla-central/rev/2efcda6dc74c63863fd8f04a6d9d7ac6b09c7eca/browser/themes/shared/preferences/preferences.inc.css#505-514 * #weavePrefsDeck (preferences): https://searchfox.org/mozilla-central/rev/2efcda6dc74c63863fd8f04a6d9d7ac6b09c7eca/browser/themes/shared/preferences/preferences.inc.css#505-514 * #fxaLoginStatus (preferences): https://searchfox.org/mozilla-central/rev/2efcda6dc74c63863fd8f04a6d9d7ac6b09c7eca/browser/themes/shared/preferences/preferences.inc.css#505-514 * #syncStatus (preferences): https://searchfox.org/mozilla-central/rev/2efcda6dc74c63863fd8f04a6d9d7ac6b09c7eca/browser/themes/shared/preferences/preferences.inc.css#505-514 Not sure: * #translationEngine: not sure, but the MS translation logo (larger child I think) has only 38px height, so it depends on the parent notification padding * #translationStates: not sure, but presumably? depends on whether the parent's default height (56px) is larger or not. Based on this, surkov's patch with visibility: collapse might be fine too (but requires tweaks to the 3 usages mentioned).
Bug 1559192 Comment 9 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
I think the way to push this patch forward is to figure out exactly what kind of sizing behaviour the <deck> usages need: Children with all the same height/usage doesn't care about the height: * ~~places.xhtml (#placesViewDeck & #detailsDeck)~~: removed in bug 1678523 * ~~old about:addons~~: removed in bug 1674890 * old perf panel: should be removed in bug 1668219 * old about:config : should be removed in bug 1524836 * #modeDeck (dialog asking you to save or open directly): both children (menulist & button) have 30px height. * .wizard-next-deck: both children are fixed-height buttons * .wizard-page-box: not sure what happens with long content, but https://searchfox.org/mozilla-central/source/toolkit/content/xul.css#544 Follows the biggest child's height (default deck behaviour): * #updateDeck (both about dialog & preferences) * #mainDeck (pageInfo window): need to re-check, but this was causing problems with lots of <meta> tags * #setDefaultPane (preferences): probably doesn't matter too much, but the one of the children is *slightly* bigger due to having the "Make default" button. Only takes the selected child height: * #PanelUI-remotetabs-deck: https://searchfox.org/mozilla-central/rev/2efcda6dc74c63863fd8f04a6d9d7ac6b09c7eca/browser/themes/shared/customizableui/panelUI.inc.css#998 * #historyPane (preferences): https://searchfox.org/mozilla-central/rev/2efcda6dc74c63863fd8f04a6d9d7ac6b09c7eca/browser/themes/shared/preferences/preferences.inc.css#505-514 * #weavePrefsDeck (preferences): https://searchfox.org/mozilla-central/rev/2efcda6dc74c63863fd8f04a6d9d7ac6b09c7eca/browser/themes/shared/preferences/preferences.inc.css#505-514 * #fxaLoginStatus (preferences): https://searchfox.org/mozilla-central/rev/2efcda6dc74c63863fd8f04a6d9d7ac6b09c7eca/browser/themes/shared/preferences/preferences.inc.css#505-514 * #syncStatus (preferences): https://searchfox.org/mozilla-central/rev/2efcda6dc74c63863fd8f04a6d9d7ac6b09c7eca/browser/themes/shared/preferences/preferences.inc.css#505-514 Not sure: * #translationEngine: not sure, but the MS translation logo (larger child I think) has only 38px height, so it depends on the parent notification padding * #translationStates: not sure, but presumably? depends on whether the parent's default height (56px) is larger or not. Based on this, surkov's patch with visibility: collapse might be fine too (but requires tweaks to the 3 usages mentioned).
I think the way to push this patch forward is to figure out exactly what kind of sizing behaviour the <deck> usages need: Children with all the same height/usage doesn't care about the height: * ~~places.xhtml (#placesViewDeck & #detailsDeck)~~: removed in bug 1678523 * ~~old about:addons~~: removed in bug 1674890 * old perf panel: should be removed in bug 1668219 * old about:config : should be removed in bug 1524836 * #modeDeck (dialog asking you to save or open directly): both children (menulist & button) have 30px height. * .wizard-next-deck: both children are fixed-height buttons * .wizard-page-box: not sure what happens with long content, but https://searchfox.org/mozilla-central/rev/88f679f68007a8042eab25e13dcefd163648d208/toolkit/content/xul.css#552 Follows the biggest child's height (default deck behaviour): * #updateDeck (both about dialog & preferences) * #mainDeck (pageInfo window): need to re-check, but this was causing problems with lots of <meta> tags * #setDefaultPane (preferences): probably doesn't matter too much, but the one of the children is *slightly* bigger due to having the "Make default" button. Only takes the selected child height: * #PanelUI-remotetabs-deck: https://searchfox.org/mozilla-central/rev/2efcda6dc74c63863fd8f04a6d9d7ac6b09c7eca/browser/themes/shared/customizableui/panelUI.inc.css#998 * #historyPane (preferences): https://searchfox.org/mozilla-central/rev/2efcda6dc74c63863fd8f04a6d9d7ac6b09c7eca/browser/themes/shared/preferences/preferences.inc.css#505-514 * #weavePrefsDeck (preferences): https://searchfox.org/mozilla-central/rev/2efcda6dc74c63863fd8f04a6d9d7ac6b09c7eca/browser/themes/shared/preferences/preferences.inc.css#505-514 * #fxaLoginStatus (preferences): https://searchfox.org/mozilla-central/rev/2efcda6dc74c63863fd8f04a6d9d7ac6b09c7eca/browser/themes/shared/preferences/preferences.inc.css#505-514 * #syncStatus (preferences): https://searchfox.org/mozilla-central/rev/2efcda6dc74c63863fd8f04a6d9d7ac6b09c7eca/browser/themes/shared/preferences/preferences.inc.css#505-514 Not sure: * #translationEngine: not sure, but the MS translation logo (larger child I think) has only 38px height, so it depends on the parent notification padding * #translationStates: not sure, but presumably? depends on whether the parent's default height (56px) is larger or not. Based on this, surkov's patch with visibility: collapse might be fine too (but requires tweaks to the 3 usages mentioned).
I think the way to push this patch forward is to figure out exactly what kind of sizing behaviour the <deck> usages need: Children with all the same height/usage doesn't care about the height: * ~~places.xhtml (#placesViewDeck & #detailsDeck)~~: removed in bug 1678523 * ~~old about:addons~~: removed in bug 1674890 * old perf panel: should be removed in bug 1668219 * ~~old about:config : should be removed in bug 1524836~~ * #modeDeck (dialog asking you to save or open directly): both children (menulist & button) have 30px height. * .wizard-next-deck: both children are fixed-height buttons * .wizard-page-box: not sure what happens with long content, but https://searchfox.org/mozilla-central/rev/88f679f68007a8042eab25e13dcefd163648d208/toolkit/content/xul.css#552 Follows the biggest child's height (default deck behaviour): * #updateDeck (both about dialog & preferences) * #mainDeck (pageInfo window): need to re-check, but this was causing problems with lots of <meta> tags * #setDefaultPane (preferences): probably doesn't matter too much, but the one of the children is *slightly* bigger due to having the "Make default" button. Only takes the selected child height: * #PanelUI-remotetabs-deck: https://searchfox.org/mozilla-central/rev/2efcda6dc74c63863fd8f04a6d9d7ac6b09c7eca/browser/themes/shared/customizableui/panelUI.inc.css#998 * #historyPane (preferences): https://searchfox.org/mozilla-central/rev/2efcda6dc74c63863fd8f04a6d9d7ac6b09c7eca/browser/themes/shared/preferences/preferences.inc.css#505-514 * #weavePrefsDeck (preferences): https://searchfox.org/mozilla-central/rev/2efcda6dc74c63863fd8f04a6d9d7ac6b09c7eca/browser/themes/shared/preferences/preferences.inc.css#505-514 * #fxaLoginStatus (preferences): https://searchfox.org/mozilla-central/rev/2efcda6dc74c63863fd8f04a6d9d7ac6b09c7eca/browser/themes/shared/preferences/preferences.inc.css#505-514 * #syncStatus (preferences): https://searchfox.org/mozilla-central/rev/2efcda6dc74c63863fd8f04a6d9d7ac6b09c7eca/browser/themes/shared/preferences/preferences.inc.css#505-514 Not sure: * #translationEngine: not sure, but the MS translation logo (larger child I think) has only 38px height, so it depends on the parent notification padding * #translationStates: not sure, but presumably? depends on whether the parent's default height (56px) is larger or not. Based on this, surkov's patch with visibility: collapse might be fine too (but requires tweaks to the 3 usages mentioned).
I think the way to push this patch forward is to figure out exactly what kind of sizing behaviour the <deck> usages need: Children with all the same height/usage doesn't care about the height: * ~~places.xhtml (#placesViewDeck & #detailsDeck)~~: removed in bug 1678523 * ~~old about:addons~~: removed in bug 1674890 * old perf panel: should be removed in bug 1668219 * ~~old about:config~~: removed in bug 1524836 * #modeDeck (dialog asking you to save or open directly): both children (menulist & button) have 30px height. * .wizard-next-deck: both children are fixed-height buttons * .wizard-page-box: not sure what happens with long content, but https://searchfox.org/mozilla-central/rev/88f679f68007a8042eab25e13dcefd163648d208/toolkit/content/xul.css#552 Follows the biggest child's height (default deck behaviour): * #updateDeck (both about dialog & preferences) * #mainDeck (pageInfo window): need to re-check, but this was causing problems with lots of <meta> tags * #setDefaultPane (preferences): probably doesn't matter too much, but the one of the children is *slightly* bigger due to having the "Make default" button. Only takes the selected child height: * #PanelUI-remotetabs-deck: https://searchfox.org/mozilla-central/rev/2efcda6dc74c63863fd8f04a6d9d7ac6b09c7eca/browser/themes/shared/customizableui/panelUI.inc.css#998 * #historyPane (preferences): https://searchfox.org/mozilla-central/rev/2efcda6dc74c63863fd8f04a6d9d7ac6b09c7eca/browser/themes/shared/preferences/preferences.inc.css#505-514 * #weavePrefsDeck (preferences): https://searchfox.org/mozilla-central/rev/2efcda6dc74c63863fd8f04a6d9d7ac6b09c7eca/browser/themes/shared/preferences/preferences.inc.css#505-514 * #fxaLoginStatus (preferences): https://searchfox.org/mozilla-central/rev/2efcda6dc74c63863fd8f04a6d9d7ac6b09c7eca/browser/themes/shared/preferences/preferences.inc.css#505-514 * #syncStatus (preferences): https://searchfox.org/mozilla-central/rev/2efcda6dc74c63863fd8f04a6d9d7ac6b09c7eca/browser/themes/shared/preferences/preferences.inc.css#505-514 Not sure: * #translationEngine: not sure, but the MS translation logo (larger child I think) has only 38px height, so it depends on the parent notification padding * #translationStates: not sure, but presumably? depends on whether the parent's default height (56px) is larger or not. Based on this, surkov's patch with visibility: collapse might be fine too (but requires tweaks to the 3 usages mentioned).
I think the way to push this patch forward is to figure out exactly what kind of sizing behaviour the <deck> usages need: Children with all the same height/usage doesn't care about the height: * ~~places.xhtml (#placesViewDeck & #detailsDeck)~~: removed in bug 1678523 * ~~old about:addons~~: removed in bug 1674890 * old perf panel: should be removed in bug 1668219 * ~~old about:config~~: removed in bug 1524836 * #modeDeck (dialog asking you to save or open directly): both children (menulist & button) have 30px height. * .wizard-next-deck: both children are fixed-height buttons * .wizard-page-box: not sure what happens with long content, but https://searchfox.org/mozilla-central/rev/88f679f68007a8042eab25e13dcefd163648d208/toolkit/content/xul.css#552 Follows the biggest child's height (default deck behaviour): * ~~#updateDeck (both about dialog & preferences)~~: removed in bug 1689727 * ~~#setDefaultPane (preferences)~~: removed in bug 1689742 Only takes the selected child height: * #PanelUI-remotetabs-deck: https://searchfox.org/mozilla-central/rev/2efcda6dc74c63863fd8f04a6d9d7ac6b09c7eca/browser/themes/shared/customizableui/panelUI.inc.css#998 * #historyPane (preferences): https://searchfox.org/mozilla-central/rev/2efcda6dc74c63863fd8f04a6d9d7ac6b09c7eca/browser/themes/shared/preferences/preferences.inc.css#505-514 * #weavePrefsDeck (preferences): https://searchfox.org/mozilla-central/rev/2efcda6dc74c63863fd8f04a6d9d7ac6b09c7eca/browser/themes/shared/preferences/preferences.inc.css#505-514 * #fxaLoginStatus (preferences): https://searchfox.org/mozilla-central/rev/2efcda6dc74c63863fd8f04a6d9d7ac6b09c7eca/browser/themes/shared/preferences/preferences.inc.css#505-514 * #syncStatus (preferences): https://searchfox.org/mozilla-central/rev/2efcda6dc74c63863fd8f04a6d9d7ac6b09c7eca/browser/themes/shared/preferences/preferences.inc.css#505-514 Not sure: * #translationEngine: not sure, but the MS translation logo (larger child I think) has only 38px height, so it depends on the parent notification padding * #translationStates: not sure, but presumably? depends on whether the parent's default height (56px) is larger or not. * #mainDeck (pageInfo window): a combination of largest child height and min-heights Based on this, going with visibility: collapse seems reasonable.
I think the way to push this patch forward is to figure out exactly what kind of sizing behaviour the <deck> usages need: Children with all the same height/usage doesn't care about the height: * ~~places.xhtml (#placesViewDeck & #detailsDeck)~~: removed in bug 1678523 * ~~old about:addons~~: removed in bug 1674890 * old perf panel: should be removed in bug 1668219 * ~~old about:config~~: removed in bug 1524836 * #modeDeck (dialog asking you to save or open directly): both children (menulist & button) have 30px height. * .wizard-next-deck: both children are fixed-height buttons * ~~.wizard-page-box~~: removed in bug 1689830 Follows the biggest child's height (default deck behaviour): * ~~#updateDeck (both about dialog & preferences)~~: removed in bug 1689727 * ~~#setDefaultPane (preferences)~~: removed in bug 1689742 Only takes the selected child height: * #PanelUI-remotetabs-deck: https://searchfox.org/mozilla-central/rev/2efcda6dc74c63863fd8f04a6d9d7ac6b09c7eca/browser/themes/shared/customizableui/panelUI.inc.css#998 * #historyPane (preferences): https://searchfox.org/mozilla-central/rev/2efcda6dc74c63863fd8f04a6d9d7ac6b09c7eca/browser/themes/shared/preferences/preferences.inc.css#505-514 * #weavePrefsDeck (preferences): https://searchfox.org/mozilla-central/rev/2efcda6dc74c63863fd8f04a6d9d7ac6b09c7eca/browser/themes/shared/preferences/preferences.inc.css#505-514 * #fxaLoginStatus (preferences): https://searchfox.org/mozilla-central/rev/2efcda6dc74c63863fd8f04a6d9d7ac6b09c7eca/browser/themes/shared/preferences/preferences.inc.css#505-514 * #syncStatus (preferences): https://searchfox.org/mozilla-central/rev/2efcda6dc74c63863fd8f04a6d9d7ac6b09c7eca/browser/themes/shared/preferences/preferences.inc.css#505-514 Not sure: * #translationEngine: not sure, but the MS translation logo (larger child I think) has only 38px height, so it depends on the parent notification padding * #translationStates: not sure, but presumably? depends on whether the parent's default height (56px) is larger or not. * #mainDeck (pageInfo window): a combination of largest child height and min-heights Based on this, going with visibility: collapse seems reasonable.