1674890 - Remove XUL decks from toolkit/mozapps/extensions/content/extensions.xhtml

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, task, P2)

Description

[Tim Nguyen :ntim]

https://searchfox.org/mozilla-central/rev/16d30bafd4e5276d6d3c632fb52a6c71e739cc44/toolkit/mozapps/extensions/content/extensions.xhtml#24-40

Not sure if more views are ever appended to the <stack> or <deck>, but if not, the structured can be flattened. IIRC, these were useful during the HTML conversion, but that's now fully finished. The hard part here is adjusting the JS/CSS accordingly.

Another way to go with this is to allow: chrome://mozapps/content/extensions/aboutaddons.html to load on its own, and the extensions.xhtml & extensions.js files can be removed altogether. That's a bit more effort though.

Comment 1

[Tim Nguyen :ntim]

Attachment: Bug 1674890 - Simplify gViewController and extensions.xhtml structure.

Comment 2

[Mark Striemer [:mstriemer]]

Attachment: Bug 1674890 - Simplify extensions.xhtml markup to just <browser> r?ntim,rpl

Comment 3

[Phabricator Automation]

Comment on attachment 9186703 [details]
Bug 1674890 - Simplify gViewController and extensions.xhtml structure.

Revision D96440 was moved to bug 1678173. Setting attachment 9186703 [details] to obsolete.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dbd38ba55b03
Simplify extensions.xhtml markup to just <browser> r=ntim,rpl

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/dbd38ba55b03e2848663b909d69179a0acd16795