1668219 - Remove the original/old Performance panel

Status: RESOLVED FIXED

(DevTools :: Performance Tools (Profiler/Timeline), task, P3)

Description

[Jan Honza Odvarko [:Honza] (always need-info? me)]

The original Performance panel should be removed entirely from the code base after we enabled the new Performance panel in Nightly (bug 1668218) and beta (bug 1693314) and Release (bug 1693316)

As part of this bug, we should also remove the on-boarding UI introduced in bug 1666815.

Honza

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

It would be great to do it before the next ESR (planned for 102)

Comment 2

[Julian Descottes [:jdescottes]]

(In reply to Nicolas Chevobbe [:nchevobbe] from comment #1)

It would be great to do it before the next ESR (planned for 102)

Honza, julien: does this sound fine to you?

Comment 3

[Julien Wajsberg [:julienw]]

Yeah that sounds good to me. I haven't seen any complaint so far.

Comment 4

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Yes, it does, let's do it.

Comment 5

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1668219 - [devtools] Remove new perf panel setting in DevTools Settings panel. r=julienw.

Comment 6

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1668219 - [devtools] Remove devtools.performance.new-panel-enabled preference. r=julienw.

Remove occurences of the pref (except in devtools/client/performance, which
will be removed further in the stack).

Depends on D145458

Comment 7

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1668219 - [devtools] Remove isNewPerfPanelEnabled target configuration. r=bomsy.

Depends on D145459

Comment 8

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1668219 - [devtools] Remove devtools/client/performance. r=julienw.

Depends on D145460

Comment 9

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1668219 - [devtools] Remove widgets only used on old perf panel. r=bomsy.

This removes FlameGraph.js, Graphs.js, GraphsWorker.js, LineGraphWidget.js, MountainGraphWidget.js
and their related tests.
DevToolsWorker tests that were relying on GraphsWorker.js are updated to use a test-specific blob worker.

Depends on D145461

Comment 10

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1668219 - [devtools] Remove now unused performance actor and front. r=julienw.

Depends on D145462

Comment 11

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1668219 - [devtools] Remove now unused performance-recording actor and front. r=julienw.

Remove files that were only used by this actor as well.

Depends on D145463

Comment 12

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1668219 - [devtools] Remove now unused devtools/shared/performance folder. r=julienw.

Depends on D145464

Comment 13

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1668219 - [devtools] Remove unused devtools/client/shared/demangle.js. r=bomsy.

It was only used in the old perf panel.

Depends on D145466

Comment 14

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1668219 - [devtools] Remove unused devtools/client/shared/options-view.js. r=bomsy.

It was only used in the old perf panel.

Depends on D145534

Comment 15

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1668219 - [devtools] Remove prefs used in old perf panel. r=bomsy.

Depends on D145535

Comment 16

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1668219 - [devtools] Remove old perf panel Telemetry historgrams. r=julienw.

Depends on D145536

Comment 17

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1668219 - [devtools] Refactor test_inspector-scroll-into-view.html . r=bomsy

Removing the framerate tests made an existing issue visible:
running test_inspector-scroll-into-view.html and then test_inspector-search-front.html
was making the latter time out.
Refactoring the test fixes the issue.

Depends on D145537

Comment 18

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/05830f228fca
[devtools] Remove new perf panel setting in DevTools Settings panel. r=julienw.
https://hg.mozilla.org/integration/autoland/rev/1e7ccf755728
[devtools] Remove devtools.performance.new-panel-enabled preference. r=julienw.
https://hg.mozilla.org/integration/autoland/rev/4685c1d23785
[devtools] Remove isNewPerfPanelEnabled target configuration. r=bomsy,devtools-backward-compat-reviewers.
https://hg.mozilla.org/integration/autoland/rev/baae6968ae34
[devtools] Remove devtools/client/performance. r=julienw.
https://hg.mozilla.org/integration/autoland/rev/855047c6f485
[devtools] Remove widgets only used on old perf panel. r=bomsy.
https://hg.mozilla.org/integration/autoland/rev/ce80be3bf0fb
[devtools] Remove now unused performance actor and front. r=julienw,devtools-backward-compat-reviewers.
https://hg.mozilla.org/integration/autoland/rev/0a850a1f7e45
[devtools] Remove now unused performance-recording actor and front. r=julienw,devtools-backward-compat-reviewers.
https://hg.mozilla.org/integration/autoland/rev/90bc436df1c6
[devtools] Remove now unused devtools/shared/performance folder. r=julienw.
https://hg.mozilla.org/integration/autoland/rev/581ce1ca7ef3
[devtools] Remove unused devtools/client/shared/demangle.js. r=bomsy.
https://hg.mozilla.org/integration/autoland/rev/b6ead515c289
[devtools] Remove unused devtools/client/shared/options-view.js. r=bomsy.
https://hg.mozilla.org/integration/autoland/rev/7e724dcf1293
[devtools] Remove prefs used in old perf panel. r=bomsy.
https://hg.mozilla.org/integration/autoland/rev/f31150b0a30e
[devtools] Remove old perf panel Telemetry historgrams. r=julienw.
https://hg.mozilla.org/integration/autoland/rev/09b25e7ee28d
[devtools] Refactor test_inspector-scroll-into-view.html . r=bomsy

Comment 19

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/05830f228fca
https://hg.mozilla.org/mozilla-central/rev/1e7ccf755728
https://hg.mozilla.org/mozilla-central/rev/4685c1d23785
https://hg.mozilla.org/mozilla-central/rev/baae6968ae34
https://hg.mozilla.org/mozilla-central/rev/855047c6f485
https://hg.mozilla.org/mozilla-central/rev/ce80be3bf0fb
https://hg.mozilla.org/mozilla-central/rev/0a850a1f7e45
https://hg.mozilla.org/mozilla-central/rev/90bc436df1c6
https://hg.mozilla.org/mozilla-central/rev/581ce1ca7ef3
https://hg.mozilla.org/mozilla-central/rev/b6ead515c289
https://hg.mozilla.org/mozilla-central/rev/7e724dcf1293
https://hg.mozilla.org/mozilla-central/rev/f31150b0a30e
https://hg.mozilla.org/mozilla-central/rev/09b25e7ee28d