After Bug 1814993, the metric for presenting the inactive tabs auto close dialog was refactored to the fragment (in the XML version, this metric lives in `InactiveTabsViewHolder`). This metric should be refactored to live, ideally, in a middleware. `TabsTray.autoCloseSeen.record(NoExtras())`
Bug 1826152 Comment 0 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
After Bug 1814993, the metric for presenting the inactive tabs auto close dialog was refactored to the fragment (in the XML version, this metric lives in `InactiveTabsViewHolder`). This metric should be refactored to live, ideally, in a middleware, otherwise into `TabsTrayController` for now. Bug 1816517 added two more metrics. All metrics are listed below. This may also be a good time to refactor the calls to `NavigationInteractor` functions and their associated logic + tests into `TabsTrayController`. ## Metrics to refactor - `TabsTray.autoCloseSeen.record(NoExtras())` - `TabsTray.shareAllTabs.record(NoExtras())` - `TabsTray.closeAllTabs.record(NoExtras())`
After Bug 1814993, the metric for presenting the inactive tabs auto close dialog was refactored to the fragment (in the XML version, this metric lives in `InactiveTabsViewHolder`). This metric should be refactored to live, ideally, in a middleware, otherwise into `TabsTrayController` for now. As part of this ticket: - Create a `TabsTrayTelemetryMiddleware` - Create `Action`s for each of the lambda callbacks in `TabsTrayFragment` and perform the expected store dispatches. - Migrate the telemetry calls to the middleware. - Stand-up unit tests for the telemetry middleware.