1147572 - Remove GetImplementationLanguage from DOMClassInfo

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Andrew McCreight [:mccr8]]

It doesn't look like it is called any more.

Comment 1

[Andrew McCreight [:mccr8]]

This definition in nsJSEnvironment.cpp also looks like it is unused:
  #define JAVASCRIPT nsIProgrammingLanguage::JAVASCRIPT

Comment 2

[Andrew McCreight [:mccr8]]

I had some minor XPCShell failure because component_import.js looks for a specific line number in an error, and I had deleted a line before that line.

Comment 3

[Andrew McCreight [:mccr8]]

Attachment: Remove implementation language field from DOM class info.

try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=a8f2a75f20f9

Comment 4

[Andrew McCreight [:mccr8]]

Attachment: Remove implementation language field from DOM class info.

Just some rebasing, plus removing some more includes now that the other DOM class info change has landed.

Comment 5

[Andrew McCreight [:mccr8]]

Thanks for the review.  I ended up removing another #include or two, I think.

https://hg.mozilla.org/integration/mozilla-inbound/rev/8854fd9c5e73

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/8854fd9c5e73

Comment 7

[Andrew McCreight [:mccr8]]

nsIClassInfo doesn't have a field named implementationLanguage any more, so people can remove it.  It doesn't hurt to just leave it there, so it isn't breaking anything, but eventually I'd like to remove the constant Components.Interfaces.nsIProgrammingLanguage.JAVASCRIPT, which is used in a number of places.

Comment 8

[aleth [:aleth]]

Not sure whether https://developer.mozilla.org/en-US/docs/Mozilla/Tech/XPCOM/Reference/Interface/nsIClassInfo should be updated to mark this as deprecated or simply remove the entry.

Comment 9

[Eric Shepherd [:sheppy]]

Updated https://developer.mozilla.org/en-US/docs/Mozilla/Tech/XPCOM/Reference/Interface/nsIClassInfo#Attributes to list the attribute as obsolete (meaning removed entirely).

Also mentioned at https://developer.mozilla.org/en-US/Firefox/Releases/40#XPCOM