Closed Bug 1147572 Opened 5 years ago Closed 5 years ago

Remove GetImplementationLanguage from DOMClassInfo

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla40
Tracking Status
firefox40 --- fixed

People

(Reporter: mccr8, Assigned: mccr8)

References

Details

(Keywords: addon-compat, dev-doc-complete)

Attachments

(1 file, 1 obsolete file)

It doesn't look like it is called any more.
This definition in nsJSEnvironment.cpp also looks like it is unused:
  #define JAVASCRIPT nsIProgrammingLanguage::JAVASCRIPT
Blocks: deadcode
Summary: From GetImplementationLanguage from DOMClassInfo → Remove GetImplementationLanguage from DOMClassInfo
Assignee: nobody → continuation
Blocks: 1147947
I had some minor XPCShell failure because component_import.js looks for a specific line number in an error, and I had deleted a line before that line.
Just some rebasing, plus removing some more includes now that the other DOM class info change has landed.
Attachment #8584756 - Attachment is obsolete: true
Attachment #8584756 - Flags: review?(jst)
Attachment #8585516 - Flags: review?(jst)
Attachment #8585516 - Flags: review?(jst) → review+
Thanks for the review.  I ended up removing another #include or two, I think.

https://hg.mozilla.org/integration/mozilla-inbound/rev/8854fd9c5e73
https://hg.mozilla.org/mozilla-central/rev/8854fd9c5e73
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
nsIClassInfo doesn't have a field named implementationLanguage any more, so people can remove it.  It doesn't hurt to just leave it there, so it isn't breaking anything, but eventually I'd like to remove the constant Components.Interfaces.nsIProgrammingLanguage.JAVASCRIPT, which is used in a number of places.
Keywords: addon-compat
Not sure whether https://developer.mozilla.org/en-US/docs/Mozilla/Tech/XPCOM/Reference/Interface/nsIClassInfo should be updated to mark this as deprecated or simply remove the entry.
Keywords: dev-doc-needed
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.