Remove GetImplementationLanguage from DOMClassInfo

RESOLVED FIXED in Firefox 40

Status

()

RESOLVED FIXED
4 years ago
3 years ago

People

(Reporter: mccr8, Assigned: mccr8)

Tracking

({addon-compat, dev-doc-complete})

Trunk
mozilla40
addon-compat, dev-doc-complete
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox40 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

4 years ago
It doesn't look like it is called any more.
(Assignee)

Comment 1

4 years ago
This definition in nsJSEnvironment.cpp also looks like it is unused:
  #define JAVASCRIPT nsIProgrammingLanguage::JAVASCRIPT
Blocks: 457262
Summary: From GetImplementationLanguage from DOMClassInfo → Remove GetImplementationLanguage from DOMClassInfo
(Assignee)

Updated

4 years ago
Assignee: nobody → continuation
(Assignee)

Updated

4 years ago
Blocks: 1147947
(Assignee)

Comment 2

4 years ago
I had some minor XPCShell failure because component_import.js looks for a specific line number in an error, and I had deleted a line before that line.
(Assignee)

Comment 3

4 years ago
Created attachment 8584756 [details] [diff] [review]
Remove implementation language field from DOM class info.

try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=a8f2a75f20f9
Attachment #8584756 - Flags: review?(jst)
(Assignee)

Comment 4

4 years ago
Created attachment 8585516 [details] [diff] [review]
Remove implementation language field from DOM class info.

Just some rebasing, plus removing some more includes now that the other DOM class info change has landed.
Attachment #8584756 - Attachment is obsolete: true
Attachment #8584756 - Flags: review?(jst)
Attachment #8585516 - Flags: review?(jst)

Updated

4 years ago
Attachment #8585516 - Flags: review?(jst) → review+
(Assignee)

Comment 5

4 years ago
Thanks for the review.  I ended up removing another #include or two, I think.

https://hg.mozilla.org/integration/mozilla-inbound/rev/8854fd9c5e73
https://hg.mozilla.org/mozilla-central/rev/8854fd9c5e73
Status: NEW → RESOLVED
Last Resolved: 4 years ago
status-firefox40: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
(Assignee)

Comment 7

4 years ago
nsIClassInfo doesn't have a field named implementationLanguage any more, so people can remove it.  It doesn't hurt to just leave it there, so it isn't breaking anything, but eventually I'd like to remove the constant Components.Interfaces.nsIProgrammingLanguage.JAVASCRIPT, which is used in a number of places.
Keywords: addon-compat

Comment 8

3 years ago
Not sure whether https://developer.mozilla.org/en-US/docs/Mozilla/Tech/XPCOM/Reference/Interface/nsIClassInfo should be updated to mark this as deprecated or simply remove the entry.
Keywords: dev-doc-needed
Updated https://developer.mozilla.org/en-US/docs/Mozilla/Tech/XPCOM/Reference/Interface/nsIClassInfo#Attributes to list the attribute as obsolete (meaning removed entirely).

Also mentioned at https://developer.mozilla.org/en-US/Firefox/Releases/40#XPCOM
Keywords: dev-doc-needed → dev-doc-complete
You need to log in before you can comment on or make changes to this bug.