Closed
Bug 1147572
Opened 9 years ago
Closed 9 years ago
Remove GetImplementationLanguage from DOMClassInfo
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla40
Tracking | Status | |
---|---|---|
firefox40 | --- | fixed |
People
(Reporter: mccr8, Assigned: mccr8)
References
Details
(Keywords: addon-compat, dev-doc-complete)
Attachments
(1 file, 1 obsolete file)
36.85 KB,
patch
|
jst
:
review+
|
Details | Diff | Splinter Review |
It doesn't look like it is called any more.
Assignee | ||
Comment 1•9 years ago
|
||
This definition in nsJSEnvironment.cpp also looks like it is unused: #define JAVASCRIPT nsIProgrammingLanguage::JAVASCRIPT
Updated•9 years ago
|
Blocks: deadcode
Summary: From GetImplementationLanguage from DOMClassInfo → Remove GetImplementationLanguage from DOMClassInfo
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → continuation
Assignee | ||
Comment 2•9 years ago
|
||
I had some minor XPCShell failure because component_import.js looks for a specific line number in an error, and I had deleted a line before that line.
Assignee | ||
Comment 3•9 years ago
|
||
try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=a8f2a75f20f9
Attachment #8584756 -
Flags: review?(jst)
Assignee | ||
Comment 4•9 years ago
|
||
Just some rebasing, plus removing some more includes now that the other DOM class info change has landed.
Attachment #8584756 -
Attachment is obsolete: true
Attachment #8584756 -
Flags: review?(jst)
Attachment #8585516 -
Flags: review?(jst)
Updated•9 years ago
|
Attachment #8585516 -
Flags: review?(jst) → review+
Assignee | ||
Comment 5•9 years ago
|
||
Thanks for the review. I ended up removing another #include or two, I think. https://hg.mozilla.org/integration/mozilla-inbound/rev/8854fd9c5e73
Comment 6•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/8854fd9c5e73
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox40:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
Assignee | ||
Comment 7•9 years ago
|
||
nsIClassInfo doesn't have a field named implementationLanguage any more, so people can remove it. It doesn't hurt to just leave it there, so it isn't breaking anything, but eventually I'd like to remove the constant Components.Interfaces.nsIProgrammingLanguage.JAVASCRIPT, which is used in a number of places.
Keywords: addon-compat
Comment 8•8 years ago
|
||
Not sure whether https://developer.mozilla.org/en-US/docs/Mozilla/Tech/XPCOM/Reference/Interface/nsIClassInfo should be updated to mark this as deprecated or simply remove the entry.
Keywords: dev-doc-needed
Comment 9•8 years ago
|
||
Updated https://developer.mozilla.org/en-US/docs/Mozilla/Tech/XPCOM/Reference/Interface/nsIClassInfo#Attributes to list the attribute as obsolete (meaning removed entirely). Also mentioned at https://developer.mozilla.org/en-US/Firefox/Releases/40#XPCOM
Keywords: dev-doc-needed → dev-doc-complete
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•