1306425 - "Tabs" in various dialogs don't render anymore, in Ubuntu 16.10 (e.g. for add-on preferences & Certificate Viewer dialog)

Status: REOPENED

(Core :: Widget: Gtk, defect, P3)

Description

[Daniel Holbert [:dholbert]]

Attachment: screenshot 1 (of AdBlock Plus "Filter Preferences" dialog)

STR:
 1. Install Ubuntu 16.10 (currently in final beta)
 2. Start Firefox with a fresh profile.
 3. Install AdBlock Plus:
     https://addons.mozilla.org/en-US/firefox/addon/adblock-plus/
 4. Click AdBlock Plus icon on toolbar, and choose "Filter Preferences"

EXPECTED RESULTS:
The Filter Preferences dialog should have two "tabs" at the top ("Filter subscriptions" and "Custom filters") which should render in a way that makes it clear they're clickable tabs.

ACTUAL RESULTS:
These "tabs" just render as text on the dialog's background, without any border / separator. See screenshot.

I believe this is a regression in Ubuntu 16.10.  Might be a bug in the Ubuntu theme or in GTK; not sure.  But for comparison, Firefox's native print dialog renders with "tabs" just fine.  So maybe we're using some newly-deprecated method for providing tabs to add-on dialogs?

Comment 1

[Daniel Holbert [:dholbert]]

This bug affects current Firefox release (49) as well as Firefox Nightly 52.0a1 (2016-09-28).

Comment 2

[Daniel Holbert [:dholbert]]

Attachment: screenshot 2 (of NoScript "Options" dialog)

This isn't specific to AdBlock Plus -- it affects e.g. NoScript, too. To see it there: Install NoScript[1], restart Firefox, and then click the NoScript icon & choose "Options".

I'm attach a screenshot of its Options dialog. The option-pane tab titles ( General Whitelist Embeddings [...]) are just text on the background) and are not clearly distinguished as tabs.

[1] https://addons.mozilla.org/en-US/firefox/addon/noscript/

Comment 3

[Daniel Holbert [:dholbert]]

Attachment: screenshot 3 (good, for comparison): working tabs in other config UI (Firefox print dialog, gedit preferences)

For comparison, here's a screenshot of what these tabs should probably look like (from a system integration perspective).  Here's the Firefox print dialog on the left, and the gedit preferences on the right. Both have tabs which are clearly visible.

Comment 4

[Daniel Holbert [:dholbert]]

Attachment: screenshot 4 (good, for comparison): NoScript "Options" dialog in Ubuntu 16.04, with working tabs

Here's a screenshot of NoScript's "Options" dialog in Ubuntu 16.04 [the previous Ubuntu release].  The tabs are nicely visible.  Compare this to screenshot 2, attachment 8796271 [details] (the same dialog but in Ubuntu 16.10).

Comment 5

[Jim Mathies [:jimm]]

This sounds like a gfx rendering problem, not a widget problem.

Daniel, have you tried safe mode?

Comment 6

[Daniel Holbert [:dholbert]]

(In reply to Jim Mathies [:jimm] from comment #5)
> This sounds like a gfx rendering problem, not a widget problem.

I was guessing "widget" (or OS integration in some form) since these "tabs" probably come from the OS theme, in some way or another, and the OS/theme is what changed when I upgraded to Ubuntu 16.10.  I guess this could conceivably be an interaction with some graphics library upgrade, too, though.

> Daniel, have you tried safe mode?

So, I *have* tried with a fresh profile, with just one or both of these add-ons installed.

It's impossible to test this in Safe Mode, as far as I know, because Safe Mode disables add-ons, and these "tabs" are in add-on dialogs.  (If these "tabs" show up anywhere else in our UI, then it would be possible to test without add-ons though.)

Comment 7

[Martin Wimpress]

I've raised the following bug report on Launchpad to track this issue in Ubuntu:

  * https://bugs.launchpad.net/ubuntu/+source/ubuntu-themes/+bug/1631208

In the comments you'll find my merge proposal for ubuntu-themes to address this issue for the Ambiance and Radiance themes in Ubuntu 16.10:

  * https://code.launchpad.net/~flexiondotorg/ubuntu-themes/lp1631208/+merge/307899

Comment 8

[Daniel Holbert [:dholbert]]

Excellent -- thank you, Martin!

Comment 9

[Daniel Holbert [:dholbert]]

I guess that means this is INVALID as a Mozilla bug, since really it seems it's a regression in the theme [which happily Martin has a fix for -- otherwise we might need to consider workarounds or somesuch].

So, since there's nothing to be done here in Mozilla code, I'll resolve this as INVALID.

Comment 10

[Daniel Holbert [:dholbert]]

This bug is visible in the Firefox's built-in "Certificate Viewer" dialog, too.

Easier STR involving that UI (no add-ons required):
 1. At some SSL page (including this one), right-click some blank space and choose "View Page Info"
 2. Click the "Security" icon at the top of the info dialog.
 3. Click "View Certificate"
 4. Look at the "General" & "Details" labels at the top.

EXPECTED RESULTS: General & Details should look like tabs (e.g. they should have a bar between them)
ACTUAL RESULTS: General & Details just look like plain text and aren't clearly separated.

Comment 11

[Daniel Holbert [:dholbert]]

Attachment: screenshot 5 (of built-in Certificate Viewer dialog)

Comment 12

[Karl Tomlinson (:karlt)]

This probably got worse with ABI changes in GTK 3.20, but there were already problems with GTK3 native tabs.

I think it is worth keeping this open to track finishing off bug 1271524.

Comment 14

[Julien Cristau [:jcristau]]

Mass wontfix for bugs affecting firefox 52.

Comment 15

[Adolfo Jayme]

Does it make sense to have this bug opened here still? The Ubuntu themes are finally getting some love from Canonical: https://code.launchpad.net/~flexiondotorg/ubuntu-themes/notebook-refactor/+merge/329593

Comment 16

[Hussam Al-Tayeb]

Maybe. Especially since this is somewhat broken as well in Adwaita (the stock gtk3 theme). A fix from Firefox's side will help everyone.