497049 - Boxes around preview images are too large

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect, P5)

Description

[Dave Garrett]

Attachment: cropped screenshot

See attached screenshot. The new skin currently has a thick light-blue border box around each preview image (not including the default). The boxes are a fixed size, with whitespace on the right if it doesn't fit. The old skin just had a thin dark sized-to-fit border.

See also bug 494475.

Comment 1

[Dave Garrett]

Vertical images have extra space on the right and horizontal images have extra space on the bottom. Looks quite iffy like this. Would be nice to just go back to a thin almost-nothing border like before.

Comment 2

[Wil Clouser [:clouserw]]

I added the whitespace for another bug because the preview images were all at different heights/widths.  I think a good solution for both bugs is to leave the hard coded height/width but move the border from being on the container to just being on the image itself (and making it smaller/darker, sure).

Comment 3

[Dave Garrett]

If you keep the spacing could you also center them in the available space? Would look odd with different sized pictures and inconsistent whitespace between them.

Comment 4

[Wil Clouser [:clouserw]]

This needs to happen for the main preview image also which is about to get duped here

Comment 6

[Wil Clouser [:clouserw]]

Behold the new design: https://addons.allizom.org/z/en-US/firefox/i/addon/xmarks-sync/