Closed
Bug 687766
Opened 13 years ago
Closed 13 years ago
Remove binary xpidl from the tree
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla9
People
(Reporter: matjk7, Assigned: matjk7)
References
Details
Attachments
(2 files, 3 obsolete files)
|
212.64 KB,
patch
|
khuey
:
review+
|
Details | Diff | Splinter Review |
|
22.18 KB,
patch
|
matjk7
:
review+
|
Details | Diff | Splinter Review |
No description provided.Flags: in-testsuite-
|
Assignee | |
Comment 1•13 years ago
|
||
Attachment #561117 -
Flags: review?(khuey)
|
|
Assignee | |
Comment 2•13 years ago
|
||
Attachment #561118 -
Flags: review?(khuey)
|
|
Assignee | |
Updated•13 years ago
|
Attachment #561118 -
Attachment is obsolete: true
Attachment #561118 -
Flags: review?(khuey)
|
|
Assignee | |
Updated•13 years ago
|
Attachment #561117 -
Attachment is obsolete: true
Attachment #561117 -
Flags: review?(khuey)
|
|
Assignee | |
Comment 3•13 years ago
|
||
First patch was overly ambitious and broke elf-dynstr-gc which uses the glib stuff from configure.
Attachment #562301 -
Flags: review?(khuey)
|
|
Assignee | |
Comment 4•13 years ago
|
||
Now with a nicer commit message.
Attachment #562302 -
Flags: review?(khuey)
Attachment #562302 -
Flags: review?(khuey) → review+
Comment on attachment 562301 [details] [diff] [review] part 1: Remove build-time dependency on libIDL Review of attachment 562301 [details] [diff] [review]: ----------------------------------------------------------------- Have you verified that this works on Windows? That's the only part of this that worries me. ::: config/system-headers @@ -404,5 @@ > libgnomevfs/gnome-vfs-mime-handlers.h > libgnomevfs/gnome-vfs-mime-utils.h > libgnomevfs/gnome-vfs-ops.h > libgnomevfs/gnome-vfs-standard-callbacks.h > -libIDL/IDL.h Should we be removing IDL.h (line 311) too?
Attachment #562301 -
Flags: review?(khuey) → review+
|
|
Assignee | |
Comment 6•13 years ago
|
||
(In reply to Kyle Huey [:khuey] (khuey@mozilla.com) from comment #5) > Have you verified that this works on Windows? That's the only part of this > that worries me. https://tbpl.mozilla.org/?tree=Try&usebuildbot=1&rev=0aba62ed8509 > Should we be removing IDL.h (line 311) too? Yes!
|
|
Assignee | |
Comment 7•13 years ago
|
||
Attachment #562301 -
Attachment is obsolete: true
Attachment #562531 -
Flags: review+
|
|
Assignee | |
Updated•13 years ago
|
Keywords: checkin-needed
|
||
Comment 8•13 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/587115c590ff https://hg.mozilla.org/integration/mozilla-inbound/rev/d1fb12e77362
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/587115c590ff https://hg.mozilla.org/mozilla-central/rev/d1fb12e77362
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla9
|
||
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•