Closed Bug 689555 Opened 12 years ago Closed 12 years ago

Fix build bustage due to mozilla-central landing bug 687766 (kill binary xpidl)

Categories

(Thunderbird :: Build Config, defect)

Product:
Thunderbird
Component:
Build Config
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: mconley, Unassigned)

References

Details

Attachments

(1 file)

aclocal.m4 fix
458 bytes, patch
Callek
: review+
Details | Diff | Splinter Review 
Bug 687766 landed in mozilla-central today (https://hg.mozilla.org/mozilla-central/rev/587115c590ff), and broke Thunderbird builds:


mconley@mconley-VirtualBox:/media/Projects/mozilla/thunderbird$ make -f client.mk
Adding client.mk options from :
    MOZ_OBJDIR=$(TOPSRCDIR)/../objdir-thunderbird-default
    MOZ_MAKE_FLAGS=-j2
Generating /media/Projects/mozilla/thunderbird/configure using autoconf
cd /media/Projects/mozilla/thunderbird; /usr/bin/autoconf2.13
/usr/bin/m4:./aclocal.m4:7: cannot open `mozilla/build/autoconf/libIDL.m4': No such file or directory
make: *** [/media/Projects/mozilla/thunderbird/configure] Error 2

I was able to fix this locally by removing the dependency on libIDL.m4.
Attached patch aclocal.m4 fix — — Splinter Review 

        Attachment #562747 -
        Flags: review?(mbanner)

    
  
Blocks: 687766

    
    

    
  
Comment on attachment 562747 [details] [diff] [review]
aclocal.m4 fix

This is the same patch I came up with, so r=me. (Provided it was tested, I was about to)

        Attachment #562747 -
        Flags: review?(mbanner) → review+

    
    

    
  
Yep, running a build with the patch right now, and things seem to be going just fine.  Thanks for the review!

    
    

    
  
Checked in: http://hg.mozilla.org/comm-central/rev/79ed2d94ef61
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED

          You need to log in
          before you can comment on or make changes to this bug.