689555 - Fix build bustage due to mozilla-central landing bug 687766 (kill binary xpidl)

Status: RESOLVED FIXED

(Thunderbird :: Build Config, defect)

Description

[Mike Conley (:mconley) (:⚙️) (Catching up on needinfos)]

Bug 687766 landed in mozilla-central today (https://hg.mozilla.org/mozilla-central/rev/587115c590ff), and broke Thunderbird builds:


mconley@mconley-VirtualBox:/media/Projects/mozilla/thunderbird$ make -f client.mk
Adding client.mk options from :
    MOZ_OBJDIR=$(TOPSRCDIR)/../objdir-thunderbird-default
    MOZ_MAKE_FLAGS=-j2
Generating /media/Projects/mozilla/thunderbird/configure using autoconf
cd /media/Projects/mozilla/thunderbird; /usr/bin/autoconf2.13
/usr/bin/m4:./aclocal.m4:7: cannot open `mozilla/build/autoconf/libIDL.m4': No such file or directory
make: *** [/media/Projects/mozilla/thunderbird/configure] Error 2

I was able to fix this locally by removing the dependency on libIDL.m4.

Comment 1

[Mike Conley (:mconley) (:⚙️) (Catching up on needinfos)]

Attachment: aclocal.m4 fix

Comment 2

[Justin Wood (:Callek)]

Comment on attachment 562747 [details] [diff] [review]
aclocal.m4 fix

This is the same patch I came up with, so r=me. (Provided it was tested, I was about to)

Comment 3

[Mike Conley (:mconley) (:⚙️) (Catching up on needinfos)]

Yep, running a build with the patch right now, and things seem to be going just fine.  Thanks for the review!

Comment 4

[Mike Conley (:mconley) (:⚙️) (Catching up on needinfos)]

Checked in: http://hg.mozilla.org/comm-central/rev/79ed2d94ef61