The default bug view has changed. See this FAQ.

Remove binary xpidl from the tree

RESOLVED FIXED in mozilla9

Status

()

Core
Build Config
RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: Matheus Kerschbaum, Assigned: Matheus Kerschbaum)

Tracking

Trunk
mozilla9
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 3 obsolete attachments)

Comment hidden (empty)
(Assignee)

Comment 1

6 years ago
Created attachment 561117 [details] [diff] [review]
part 1: Remove build-time dependency on glib and libIDL
Attachment #561117 - Flags: review?(khuey)
(Assignee)

Comment 2

6 years ago
Created attachment 561118 [details] [diff] [review]
part 2: Nuke binary xpidl
Attachment #561118 - Flags: review?(khuey)
(Assignee)

Updated

6 years ago
Attachment #561118 - Attachment is obsolete: true
Attachment #561118 - Flags: review?(khuey)
(Assignee)

Updated

6 years ago
Attachment #561117 - Attachment is obsolete: true
Attachment #561117 - Flags: review?(khuey)
(Assignee)

Comment 3

6 years ago
Created attachment 562301 [details] [diff] [review]
part 1: Remove build-time dependency on libIDL

First patch was overly ambitious and broke elf-dynstr-gc which uses the glib stuff from configure.
Attachment #562301 - Flags: review?(khuey)
(Assignee)

Comment 4

6 years ago
Created attachment 562302 [details] [diff] [review]
part 2: Nuke binary xpidl

Now with a nicer commit message.
Attachment #562302 - Flags: review?(khuey)
Attachment #562302 - Flags: review?(khuey) → review+
Comment on attachment 562301 [details] [diff] [review]
part 1: Remove build-time dependency on libIDL

Review of attachment 562301 [details] [diff] [review]:
-----------------------------------------------------------------

Have you verified that this works on Windows?  That's the only part of this that worries me.

::: config/system-headers
@@ -404,5 @@
>  libgnomevfs/gnome-vfs-mime-handlers.h
>  libgnomevfs/gnome-vfs-mime-utils.h
>  libgnomevfs/gnome-vfs-ops.h
>  libgnomevfs/gnome-vfs-standard-callbacks.h
> -libIDL/IDL.h

Should we be removing IDL.h (line 311) too?
Attachment #562301 - Flags: review?(khuey) → review+
(Assignee)

Comment 6

6 years ago
(In reply to Kyle Huey [:khuey] (khuey@mozilla.com) from comment #5)
> Have you verified that this works on Windows?  That's the only part of this
> that worries me.

https://tbpl.mozilla.org/?tree=Try&usebuildbot=1&rev=0aba62ed8509

> Should we be removing IDL.h (line 311) too?

Yes!
(Assignee)

Comment 7

6 years ago
Created attachment 562531 [details] [diff] [review]
part 1: Remove build-time dependency on libIDL
Attachment #562301 - Attachment is obsolete: true
Attachment #562531 - Flags: review+
(Assignee)

Updated

6 years ago
Keywords: checkin-needed
https://hg.mozilla.org/integration/mozilla-inbound/rev/587115c590ff
https://hg.mozilla.org/integration/mozilla-inbound/rev/d1fb12e77362
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/587115c590ff
https://hg.mozilla.org/mozilla-central/rev/d1fb12e77362
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla9
Depends on: 689555
Duplicate of this bug: 686692
(Assignee)

Updated

5 years ago
Blocks: 709793
You need to log in before you can comment on or make changes to this bug.