687766 - Remove binary xpidl from the tree

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Comment 1

[Matheus Kerschbaum]

Attachment: part 1: Remove build-time dependency on glib and libIDL

Comment 2

[Matheus Kerschbaum]

Attachment: part 2: Nuke binary xpidl

Comment 3

[Matheus Kerschbaum]

Attachment: part 1: Remove build-time dependency on libIDL

First patch was overly ambitious and broke elf-dynstr-gc which uses the glib stuff from configure.

Comment 4

[Matheus Kerschbaum]

Attachment: part 2: Nuke binary xpidl

Now with a nicer commit message.

Comment 5

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Comment on attachment 562301 [details] [diff] [review]
part 1: Remove build-time dependency on libIDL

Review of attachment 562301 [details] [diff] [review]:
-----------------------------------------------------------------

Have you verified that this works on Windows?  That's the only part of this that worries me.

::: config/system-headers
@@ -404,5 @@
>  libgnomevfs/gnome-vfs-mime-handlers.h
>  libgnomevfs/gnome-vfs-mime-utils.h
>  libgnomevfs/gnome-vfs-ops.h
>  libgnomevfs/gnome-vfs-standard-callbacks.h
> -libIDL/IDL.h

Should we be removing IDL.h (line 311) too?

Comment 6

[Matheus Kerschbaum]

(In reply to Kyle Huey [:khuey] ([e-mail]) from comment #5)
> Have you verified that this works on Windows?  That's the only part of this
> that worries me.

https://tbpl.mozilla.org/?tree=Try&usebuildbot=1&rev=0aba62ed8509

> Should we be removing IDL.h (line 311) too?

Yes!

Comment 7

[Matheus Kerschbaum]

Attachment: part 1: Remove build-time dependency on libIDL

Comment 8

[Dão Gottwald [:dao]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/587115c590ff
https://hg.mozilla.org/integration/mozilla-inbound/rev/d1fb12e77362

Comment 9

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

https://hg.mozilla.org/mozilla-central/rev/587115c590ff
https://hg.mozilla.org/mozilla-central/rev/d1fb12e77362