Closed
Bug 1000191
Opened 10 years ago
Closed 10 years ago
[NFC] |NfcPeer.sendNDEF| fails on emulator
Categories
(Firefox OS Graveyard :: NFC, defect)
Tracking
(blocking-b2g:2.0+, b2g-v2.0 fixed)
Tracking | Status | |
---|---|---|
b2g-v2.0 | --- | fixed |
People
(Reporter: tzimmermann, Assigned: allstars.chh)
References
Details
(Whiteboard: [p=1])
Attachments
(1 file)
6.62 KB,
patch
|
dlee
:
review+
tzimmermann
:
feedback+
|
Details | Diff | Splinter Review |
NFC is enabled, but |NfcPeer.sendNDEF| fails because |NFC._enabled| is false. I can reproduce this with the test case that is attached to bug 980851.
Reporter | ||
Comment 1•10 years ago
|
||
Yoshi, this started happening after rebasing on bugs 970263 and 970251. Could you take a look?
Flags: needinfo?(allstars.chh)
Reporter | ||
Comment 2•10 years ago
|
||
I can out-comment the test near Nfc.js:579 to make NfcPeer.sendNDEF work.
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → allstars.chh
Flags: needinfo?(allstars.chh)
Updated•10 years ago
|
blocking-b2g: --- → 2.0+
Assignee | ||
Updated•10 years ago
|
Summary: [NFC] |NfcPeer.sendNDEF| fails → [NFC] |NfcPeer.sendNDEF| fails on emulator
Assignee | ||
Comment 3•10 years ago
|
||
Didn't have a test case because we still need to fix Bug 987596 first.
Assignee | ||
Updated•10 years ago
|
Attachment #8411659 -
Flags: review?(dlee)
Reporter | ||
Comment 4•10 years ago
|
||
(In reply to Yoshi Huang[:allstars.chh] from comment #3) > Created attachment 8411659 [details] [diff] [review] > Patch > > Didn't have a test case because we still need to fix Bug 987596 first. Thanks Yoshi. I'll test this locally.
Reporter | ||
Comment 5•10 years ago
|
||
Comment on attachment 8411659 [details] [diff] [review] Patch Review of attachment 8411659 [details] [diff] [review]: ----------------------------------------------------------------- Works.
Attachment #8411659 -
Flags: feedback+
Updated•10 years ago
|
Attachment #8411659 -
Flags: review?(dlee) → review+
Assignee | ||
Comment 6•10 years ago
|
||
https://hg.mozilla.org/integration/b2g-inbound/rev/1778e4c2abd7
Comment 7•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/1778e4c2abd7
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2.0 S1 (9may)
Updated•10 years ago
|
status-b2g-v2.0:
--- → fixed
Assignee | ||
Updated•10 years ago
|
Whiteboard: [p=1]
You need to log in
before you can comment on or make changes to this bug.
Description
•