Closed
Bug 1001055
Opened 11 years ago
Closed 11 years ago
[tarako] disable install buttons for apps when user is offline
Categories
(Marketplace Graveyard :: Consumer Pages, defect, P2)
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: ddurst, Assigned: spasovski)
References
Details
(Keywords: perf)
"Install" buttons should be disabled (using the existing styles) when the user is offline.
Reporter | ||
Updated•11 years ago
|
Reporter | ||
Comment 1•11 years ago
|
||
With the app no longer attempting to be useful "offline", there remains a window of time when the app is loading that cached data may be shown -- in those cases, we should still disable these buttons until the user is online.
This will likely overlap slightly with bug 1001782, bug 1001775, and bug 1001096 -- which are pending input from UX.
Priority: -- → P2
Comment 2•11 years ago
|
||
I'd recommend having them shown as normal, but if they are offline when they click it, show a notification stating they can't install offline.
Reporter | ||
Comment 3•11 years ago
|
||
Agree with ngoke. Ideally, this is an overlay and not a full-screen error message.
Comment 4•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Comment 5•11 years ago
|
||
Reverted.
However, the system may raise "NETWORK_ERR" on its own.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee | ||
Comment 6•11 years ago
|
||
This is the proper fix:
https://github.com/mozilla/yogafire/compare/6820b14856f1...d05b66255b83
Status: REOPENED → RESOLVED
Closed: 11 years ago → 11 years ago
Resolution: --- → FIXED
Comment 7•11 years ago
|
||
Comment 8•11 years ago
|
||
we now show a usermessage instead of keeping the buttons disabled.
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•