Closed Bug 1001055 Opened 10 years ago Closed 10 years ago

[tarako] disable install buttons for apps when user is offline

Categories

(Marketplace Graveyard :: Consumer Pages, defect, P2)

x86
macOS
defect

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: ddurst, Assigned: spasovski)

References

Details

(Keywords: perf)

"Install" buttons should be disabled (using the existing styles) when the user is offline.
Blocks: 1000301
No longer blocks: 998811
With the app no longer attempting to be useful "offline", there remains a window of time when the app is loading that cached data may be shown -- in those cases, we should still disable these buttons until the user is online.

This will likely overlap slightly with bug 1001782, bug 1001775, and bug 1001096 -- which are pending input from UX.
Priority: -- → P2
I'd recommend having them shown as normal, but if they are offline when they click it, show a notification stating they can't install offline.
Agree with ngoke. Ideally, this is an overlay and not a full-screen error message.
https://github.com/mozilla/yogafire/commit/507897d5451527f9ca2a4bad2a0aa5f2298ac9c6
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Reverted.

However, the system may raise "NETWORK_ERR" on its own.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
This is the proper fix:

https://github.com/mozilla/yogafire/compare/6820b14856f1...d05b66255b83
Status: REOPENED → RESOLVED
Closed: 10 years ago10 years ago
Resolution: --- → FIXED
we now show a usermessage instead of keeping the buttons disabled.
Status: RESOLVED → VERIFIED
Blocks: 992365
You need to log in before you can comment on or make changes to this bug.