1001285 - [Settings] Messaging Settings UX update

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Omega Feng [:Omega] [:馮於懋]]

Attachment: [1.5 Settings] Messaging Settings v1.0.pdf

The latest UX spec.

Comment 1

[Fernando Campo (:fcampo)]

Hi Omega, 

- how do you want to deal with multi-SIM situations? should we show both? or just default SIM information?
- What should we do when the info is not available? hide the entire section? or show a message to the user? e.g. 'Not available'

Comment 2

[Omega Feng [:Omega] [:馮於懋]]

@Carrie, it looks like DSDS. Can you help one this? Thanks!

Comment 3

[Carrie Wang [New account: [e-mail]]]

Attachment: [1.4 DSDS] DSDS guideline_v0.1.pdf

Hi, please refer to p.32. We will add two entry points for SIM 1 and SIM 2. I think the settings here in Messages APP should be the same. ni? Jenny (Messages APP UX) for spec updated. Thanks!

Comment 4

[Jenny Lee]

Attachment: [2.1 Settings] Message Settings v1.1.pdf

Hello, please refer to the spec for updated SMSC design. Thanks!

Comment 5

[Jenny Lee]

Attachment: [2.1 Settings] Message Settings v1.2.pdf

Hi all, please refer to the latest Message setting spec. Thanks!

Comment 6

[Arthur Chen [:arthurcc][inactive after 6/30]]

Note that the bug is considered as the DSDS support for messaging settings.

Comment 7

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Ok, it's time to start to work on this feature ;)

Comment 9

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Attachment: patch on master

Comment 10

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Comment on attachment 8469940 [details] [review]
patch on master

Arthur,

I just finished the first prototype of messaging settings. Please help me check it when you have time ! Thanks :)

Comment 11

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8469940 [details] [review]
patch on master

Looks good to me! But I found one issue, which is that I am not able to back to the messaging panel from the sim specific panel at the second time.

Comment 12

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Comment on attachment 8469940 [details] [review]
patch on master

Arthur, just fixed tests and addressed nits. Please help me review it when you have time, thanks :)

Comment 13

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8469940 [details] [review]
patch on master

Please check my comments in github, thanks!

Comment 14

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Comment on attachment 8469940 [details] [review]
patch on master

Hi Arthur,

just addressed comments from github and plz give it a check when you have time  !Thanks :)

Comment 15

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8469940 [details] [review]
patch on master

Good job! r=me, thank you!

Comment 16

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Comment on attachment 8469940 [details] [review]
patch on master

Hi Zac, can you help me review the code about disabling one test case in Gip ?

The reason why we have to disable this is because the test case makes no sense in desktop-b2g. If you are using any devices without sims inserted or without sim slots, you should not be able to access the messaging panel no matter how, so this test case should be kept on devices tests only.

Thanks !

Comment 17

[Zac C (:zac)]

Comment on attachment 8469940 [details] [review]
patch on master

f+ only from me.

The disabling makes sense. When we have the mock-RIL in desktopb2g then we'll be able to run this test on desktopb2g.

Comment 18

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Ok thanks Zac ! Let's enabling this back when mock-RIL is ready in desktop b2g.

Comment 19

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Thanks all, this patch was merged into Gaia/master : https://github.com/mozilla-b2g/gaia/commit/b4d5b2c797b39b02f09435830f7478a4b4c305d3#diff-d41d8cd98f00b204e9800998ecf8427e

Comment 20

[Michael Schwartz [:m4]]

This seems to have broken cell broadcast http://mxr.mozilla.org/gaia/source/apps/system/js/cell_broadcast_system.js#6 although the fix is small.  Is there another bug to address all other uses of the same setting?

Comment 21

[Anshul]

M4, please file a new bug for this issue and add a reference to this one.

Comment 22

[Michael Schwartz [:m4]]

Added new bug https://bugzilla.mozilla.org/show_bug.cgi?id=1068978