1001324 - The Downloads Panel footer should use the same style as the application menu

Status: VERIFIED FIXED

(Firefox :: Theme, defect)

Description

[Tim Nguyen :ntim]

Pros of doing this :
- Matches better shorlander's design
- In sync with other panel footer styling
- Makes the styling consistent across platforms

Cons :
- It's not a subview

Comment 1

[Dão Gottwald [:dao]]

(In reply to Tim Nguyen [:ntim] from comment #0)
> Cons :
> - It's not a subview

Exactly. If we want to pursue this bug, we need to either duplicate the styling or introduce a more generic class.

Comment 2

[:Gijs (he/him)]

(In reply to Dão Gottwald [:dao] from comment #1)
> (In reply to Tim Nguyen [:ntim] from comment #0)
> > Cons :
> > - It's not a subview
> 
> Exactly. If we want to pursue this bug, we need to either duplicate the
> styling or introduce a more generic class.

I was under the impression we already had a bug to make the downloads panel use a proper subview (bug 947250), so that it works well when it's in the panel. That'd also fix this bug. I'm not sure it's worth keeping separately; certainly I wouldn't really prioritize this one whereas the other one is already in the backlog (and, I think, a UX priority from what I remember from the relevant etherpads). I'm inclined to mark as a dupe because of this, because I think "on its own", fixing this bug provides little to no value. Dão, does that make sense to you?

Comment 3

[Dão Gottwald [:dao]]

I don't care either way. I certainly wasn't going to work on this bug.

Comment 4

[Tim Nguyen :ntim]

(In reply to Dão Gottwald [:dao] from comment #1)
> (In reply to Tim Nguyen [:ntim] from comment #0)
> > Cons :
> > - It's not a subview
> 
> Exactly. If we want to pursue this bug, we need to either duplicate the
> styling or introduce a more generic class.

FYI, the australis widget panels are not subviews, and they still use the panel-subview-footer/header class.

Comment 5

[:Paolo Amadini]

I'll use this bug to update the Downloads Panel footer styles to match the application menu. A few styling bugs with the new Downloads Panel subview are fixed at the same time.

Reusing the existing styles is being discussed in bug 1288747 and implemented in bug 1291682.

Comment 6

[:Paolo Amadini]

Attachment: Bug 1001324 - The Downloads Panel footer should use the same style as the application menu.

Review commit: https://reviewboard.mozilla.org/r/69568/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/69568/

Comment 7

[:Paolo Amadini]

This also fixes a few styling bugs with the subview like the transition duration in Windows 7.

Comment 8

[Tim Nguyen :ntim]

Can we use CSS variables to keep everything in sync ?
See https://bug1146044.bmoattachments.org/attachment.cgi?id=8597232 for a WIP patch.

Comment 9

[:Paolo Amadini]

[Tracking Requested - why for this release]:
This improves the styling and fixes a few minor bugs for a feature developed for Firefox 50 in bug 1252509.

Comment 10

[:Paolo Amadini]

(In reply to Tim Nguyen :ntim (use needinfo?) from comment #8)
> Can we use CSS variables to keep everything in sync ?

We will, that's however only part of the story.

Comment 11

[Drew Willcoxon :adw]

Comment on attachment 8778255 [details]
Bug 1001324 - The Downloads Panel footer should use the same style as the application menu.

https://reviewboard.mozilla.org/r/69568/#review66734

Comment 12

[:Paolo Amadini]

Attachment: Screenshot of main view on Windows 7

Comment 13

[:Paolo Amadini]

Attachment: Screenshot of subview on Windows 7

Comment 14

[:Paolo Amadini]

Attachment: Screenshot of main view on Mac OS X 10.9

Comment 15

[:Paolo Amadini]

Attachment: Screenshot of subview on Mac OS X 10.9

Comment 16

[:Paolo Amadini]

Attachment: Screenshot of main view on Linux

Comment 17

[:Paolo Amadini]

Attachment: Screenshot of subview on Linux

Comment 18

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/fx-team/rev/204a7ba2fba4
The Downloads Panel footer should use the same style as the application menu. r=adw

Comment 19

[:Paolo Amadini]

Thanks for the quick review! I landed this with a small change, I had to use "border: 0" instead of "border-width: 0" to override the three-dimensional border color for the separator on Windows, a small difference that I just noticed in the large screenshot.

Comment 20

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/204a7ba2fba4

Comment 21

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Hello Paolo, could you please nominate a patch for uplift to Aurora as Fx50 is affected by this bug?

Comment 22

[:Paolo Amadini]

Comment on attachment 8778255 [details]
Bug 1001324 - The Downloads Panel footer should use the same style as the application menu.

Approval Request Comment
[Feature/regressing bug #]: Downloads subview (bug 1252509)
[User impact if declined]: Incorrect visual style
[Describe test coverage new/current, TreeHerder]: Tested on mozilla-central
[Risks and why]: Low, only CSS and class changes
[String/UUID change made/needed]: None

Comment 23

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8778255 [details]
Bug 1001324 - The Downloads Panel footer should use the same style as the application menu.

Stabilized on Nightly for 2 weeks, fixes visual effects for a feature tracked for 50, let's uplift to Aurora.

Comment 24

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/2d7fe7b74988

Comment 25

[Saheda Reza [:Antora]]

I have successfully reproduced this bug on nightly according to(2014-04-25)

Fixing bug is verified on Latest Firefox Nightly-- Build ID: ( 20160826030226 ), User Agent 	Mozilla/5.0 (Windows NT 10.0; rv:51.0) Gecko/20100101 Firefox/51.0


Tested OS -- Windows10 32bit

Comment 26

[Saheda Reza [:Antora]]

(In reply to Saheda Reza [:Antora] from comment #25)
> I have successfully reproduced this bug on nightly according to(2014-04-25)
> 
> Fixing bug is verified on Latest Firefox Nightly-- Build ID: (
> 20160826030226 ), User Agent 	Mozilla/5.0 (Windows NT 10.0; rv:51.0)
> Gecko/20100101 Firefox/51.0
> 
> 
> Tested OS -- Windows10 32bit


And Also verified on Latest Developer Edition--  Build ID:( 20160826004001 ), User Agent: Mozilla/5.0 (Windows NT 10.0; rv:50.0) Gecko/20100101 Firefox/50.0

Comment 27

[Jared Wein [:jaws] (please needinfo? me)]

Thanks!