Closed Bug 1001324 Opened 6 years ago Closed 4 years ago

The Downloads Panel footer should use the same style as the application menu

Categories

(Firefox :: Theme, defect)

defect
Not set

Tracking

()

VERIFIED FIXED
Firefox 51
Tracking Status
firefox50 + verified
firefox51 --- verified

People

(Reporter: ntim, Assigned: Paolo)

References

Details

(Whiteboard: [Australis:P5])

Attachments

(7 files)

Pros of doing this :
- Matches better shorlander's design
- In sync with other panel footer styling
- Makes the styling consistent across platforms

Cons :
- It's not a subview
(In reply to Tim Nguyen [:ntim] from comment #0)
> Cons :
> - It's not a subview

Exactly. If we want to pursue this bug, we need to either duplicate the styling or introduce a more generic class.
Summary: Make the downloads footer use the panel-subview-footer class → Downloads footer should use the same style as the panel-subview-footer class
Whiteboard: [Australis:P4] → [Australis:P5]
(In reply to Dão Gottwald [:dao] from comment #1)
> (In reply to Tim Nguyen [:ntim] from comment #0)
> > Cons :
> > - It's not a subview
> 
> Exactly. If we want to pursue this bug, we need to either duplicate the
> styling or introduce a more generic class.

I was under the impression we already had a bug to make the downloads panel use a proper subview (bug 947250), so that it works well when it's in the panel. That'd also fix this bug. I'm not sure it's worth keeping separately; certainly I wouldn't really prioritize this one whereas the other one is already in the backlog (and, I think, a UX priority from what I remember from the relevant etherpads). I'm inclined to mark as a dupe because of this, because I think "on its own", fixing this bug provides little to no value. Dão, does that make sense to you?
Flags: needinfo?(dao)
I don't care either way. I certainly wasn't going to work on this bug.
Flags: needinfo?(dao)
(In reply to Dão Gottwald [:dao] from comment #1)
> (In reply to Tim Nguyen [:ntim] from comment #0)
> > Cons :
> > - It's not a subview
> 
> Exactly. If we want to pursue this bug, we need to either duplicate the
> styling or introduce a more generic class.

FYI, the australis widget panels are not subviews, and they still use the panel-subview-footer/header class.
I'll use this bug to update the Downloads Panel footer styles to match the application menu. A few styling bugs with the new Downloads Panel subview are fixed at the same time.

Reusing the existing styles is being discussed in bug 1288747 and implemented in bug 1291682.
Assignee: nobody → paolo.mozmail
Blocks: 1291682
Status: NEW → ASSIGNED
Summary: Downloads footer should use the same style as the panel-subview-footer class → The Downloads Panel footer should use the same style as the application menu
This also fixes a few styling bugs with the subview like the transition duration in Windows 7.
Blocks: 1252509
Can we use CSS variables to keep everything in sync ?
See https://bug1146044.bmoattachments.org/attachment.cgi?id=8597232 for a WIP patch.
[Tracking Requested - why for this release]:
This improves the styling and fixes a few minor bugs for a feature developed for Firefox 50 in bug 1252509.
(In reply to Tim Nguyen :ntim (use needinfo?) from comment #8)
> Can we use CSS variables to keep everything in sync ?

We will, that's however only part of the story.
Comment on attachment 8778255 [details]
Bug 1001324 - The Downloads Panel footer should use the same style as the application menu.

https://reviewboard.mozilla.org/r/69568/#review66734
Attachment #8778255 - Flags: review?(adw) → review+
Pushed by paolo.mozmail@amadzone.org:
https://hg.mozilla.org/integration/fx-team/rev/204a7ba2fba4
The Downloads Panel footer should use the same style as the application menu. r=adw
Thanks for the quick review! I landed this with a small change, I had to use "border: 0" instead of "border-width: 0" to override the three-dimensional border color for the separator on Windows, a small difference that I just noticed in the large screenshot.
Flags: qe-verify+
https://hg.mozilla.org/mozilla-central/rev/204a7ba2fba4
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 51
Depends on: 1293023
Hello Paolo, could you please nominate a patch for uplift to Aurora as Fx50 is affected by this bug?
Flags: needinfo?(paolo.mozmail)
Comment on attachment 8778255 [details]
Bug 1001324 - The Downloads Panel footer should use the same style as the application menu.

Approval Request Comment
[Feature/regressing bug #]: Downloads subview (bug 1252509)
[User impact if declined]: Incorrect visual style
[Describe test coverage new/current, TreeHerder]: Tested on mozilla-central
[Risks and why]: Low, only CSS and class changes
[String/UUID change made/needed]: None
Flags: needinfo?(paolo.mozmail)
Attachment #8778255 - Flags: approval-mozilla-aurora?
Comment on attachment 8778255 [details]
Bug 1001324 - The Downloads Panel footer should use the same style as the application menu.

Stabilized on Nightly for 2 weeks, fixes visual effects for a feature tracked for 50, let's uplift to Aurora.
Attachment #8778255 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
I have successfully reproduced this bug on nightly according to(2014-04-25)

Fixing bug is verified on Latest Firefox Nightly-- Build ID: ( 20160826030226 ), User Agent 	Mozilla/5.0 (Windows NT 10.0; rv:51.0) Gecko/20100101 Firefox/51.0


Tested OS -- Windows10 32bit
QA Whiteboard: [testday-20160826]
(In reply to Saheda Reza [:Antora] from comment #25)
> I have successfully reproduced this bug on nightly according to(2014-04-25)
> 
> Fixing bug is verified on Latest Firefox Nightly-- Build ID: (
> 20160826030226 ), User Agent 	Mozilla/5.0 (Windows NT 10.0; rv:51.0)
> Gecko/20100101 Firefox/51.0
> 
> 
> Tested OS -- Windows10 32bit


And Also verified on Latest Developer Edition--  Build ID:( 20160826004001 ), User Agent: Mozilla/5.0 (Windows NT 10.0; rv:50.0) Gecko/20100101 Firefox/50.0
You need to log in before you can comment on or make changes to this bug.