remove deprecated content-script globals `onMessage` and `on`

RESOLVED FIXED in mozilla35

Status

Add-on SDK
General
P2
normal
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: zombie, Assigned: yt, Mentored)

Tracking

unspecified
mozilla35

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [diamond] [good first bug] [lang=js])

Attachments

(1 attachment)

47 bytes, text/x-github-pull-request
zombie
: review+
Details | Review | Splinter Review
(Reporter)

Description

3 years ago
deprecated for 3 years now (bug 653187), and throwing errors (thus not accepted on AMO) for a year and a half (bug 785826).

https://github.com/mozilla/addon-sdk/blob/master/lib/sdk/content/content-worker.js#L289
(Reporter)

Comment 1

3 years ago
err, not so much "throwing" errors as "logging" them.

Updated

3 years ago
Priority: -- → P2
Whiteboard: [good first bug]

Comment 2

3 years ago
A priority rating makes this a [diamond] bug.
Whiteboard: [good first bug] → [diamond] [good first bug] [lang=js]
(Assignee)

Comment 3

3 years ago
I am interested on working on this bug as part of the Mozilla Ascend Project. I've cloned the add-on sdk repo from Github and found the deprecated "onMessage" and "on" script globals that need to be removed. I noticed that there is no mentor or QA contact for the bug and I was wondering who I should direct my correspondence to. Thanks.

Comment 4

3 years ago
Hi, Pareiamadi. Thanks for your interest!

Tomislav, feel like mentoring this one?
Flags: needinfo?(tomica+amo)
(Reporter)

Comment 5

3 years ago
hi Peri (and Mike), I can mentor for this one.

please check out the contributing guidelines:
https://github.com/mozilla/addon-sdk/blob/master/CONTRIBUTING.md

in short, instead cloning the original repo from github, i suggest you:

1) open a github account
2) "fork" the addon-sdk repo to your own account and clone that one
3) create (and checkout) a branch with a name like "1001466-remove-deprecated-on"
4) make your changes, which in this case might be just removing the code
5) run the tests to ensure nothing broke
...
when done:

6) commit your changes with appropriate message like "bug 1001466 - description.."
7) push your changes, go to github.com and click the "create Pull Request" button
9) copy/paste the PR link as an attachment here, and flag for review? from me

if you get stuck, or just wanna chat, feel free to ask, here or even better in IRC (if you are familiar with it), channel #jetpack on irc.mozilla.org -- i'm in Europe, but usually stay around during US working hours..
Mentor: tomica+amo@gmail.com
Flags: needinfo?(tomica+amo)
Assigning to Peri while she is working on this during the Ascend Project.  She should have a patch shortly.
Assignee: nobody → periahmadi
(Assignee)

Comment 7

3 years ago
Created attachment 8502048 [details] [review]
Pull request #1676

Here's my first patch. Test results came back with no diff so I can only assume it worked? Here's hoping.
Attachment #8502048 - Flags: review?(tomica+amo)
(Reporter)

Comment 8

3 years ago
Comment on attachment 8502048 [details] [review]
Pull request #1676

good work Peri!  r=me

sorry for all the trouble you had with setting up the dev environment. but now that you have it sorted out, maybe you want to try another simple bug, to "amortize" the costs? ;)

if you are up for it, i can try and find something just slightly more challenging..
Attachment #8502048 - Flags: review?(tomica+amo) → review+
(Reporter)

Comment 9

3 years ago
(oh btw, not going to land this right now, our tree is orange ATM)

https://tbpl.mozilla.org/?tree=Jetpack
Status: NEW → ASSIGNED
(Assignee)

Comment 10

3 years ago
Sure thing, sock it to me. :)

Comment 11

3 years ago
Commits pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/4e0aa9fb021d3ce91a61df6d86be56d63f1a44c8
bug 1001466removed deprecated content first patch

https://github.com/mozilla/addon-sdk/commit/2a63bfec52c50df3215d2709f309b1a8eca8f5ef
Merge pull request #1676 from y-t-/1001466-remove-deprecated-on

bug 1001466 - removed deprecated onMessage, r=@zombie
(Reporter)

Comment 12

3 years ago
awesome to hear that. i went through our [good first bugs], and found 3 to suggest to you:

bug 856968 this should be some simple hacking, in python this time
bug 868507 this is documentation work on MDN, updating some code samples
bug 1081520 is similarly about updating some code, but this tome in modules and tests

take a look, claim one that you feel like you can do, and i can mentor again if you want.
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
You need to log in before you can comment on or make changes to this bug.