1002355 - [Stingray] A helper to wrap functions of mozApps.mgmt

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

Description

[Luke Chang [:lchang] (inactive)]

This helper is responsible for:

1. get all installed apps
2. get app icon blob
3. listen to app install/update/uninstall events
4. launch an app

Comment 1

[Kevin Grandon :kgrandon]

Hey Luke. I'm currently planning a refactoring of this type of functionality for the new phone homescreen. Part of the thing that makes it a bit painful is that it probably needs to default the item grid and save some data to indexedDB. Anyway - as I might refactor this soon, it might be good to think if there is any shared/ library support we could create to use in both homescreens. The phone case might actually be more complex here because we need to support carrier customization and placement of icons.

We're currently doing this here: https://github.com/mozilla-b2g/gaia/blob/master/dev_apps/home2/js/sources/application.js#L18

Comment 2

[Luke Chang [:lchang] (inactive)]

Hi Kevin,

It sounds good if there is a shared library for both homescreens.

As you've said, this kind of library in phone case might be more complex than in stingray so my initial plan is trying to split the functionality of mozApps.mgmt into a helper (this bug) and a renderer (bug 1002358). This helper is a library which only cases about UI-independent functionality so that we can switch to any other renderers and easier to support customization. What do you think?

Here is our draft version: https://github.com/luke-chang/gaia/blob/TV_arch1/test_apps/homescreen-tv-arch1/js/applications.js

Comment 3

[Luke Chang [:lchang] (inactive)]

Attachment: Pull Request 19089

A simple wrapper for mozApp.mgmt. Please help to review it when you're available. Thanks a lot.

Comment 4

[John Hu [:johnhu][:johu][:醬糊小弟]]

Comment on attachment 8419870 [details] [review]
Pull Request 19089

Nice work. I don't have any concern about this patch.

Comment 5

[John Hu [:johnhu][:johu][:醬糊小弟]]

Don't forget to rebase the code and move tests to _test_ folder.

Comment 6

[GaryChen [:GaryChen][:PYChen][:gchen][:陳柏宇]]

Comment on attachment 8419870 [details] [review]
Pull Request 19089

Nice work, r=me after using manifest URL instead of app origin.

Comment 7

[Luke Chang [:lchang] (inactive)]

travis passed:
https://travis-ci.org/mozilla-b2g/gaia/builds/24948333

merged in gaia master branch:
https://github.com/mozilla-b2g/gaia/commit/6318565c4d6869ace6f2478a1e8282bf3979cb2c

Gary, John, Thanks a lot!

Comment 8

[Luke Chang [:lchang] (inactive)]

Comment on attachment 8419870 [details] [review]
Pull Request 19089

Clear review flag since this patch already got two r+.