Closed Bug 1002358 Opened 6 years ago Closed 6 years ago

[Stingray] App List Implementation

Categories

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: lchang, Assigned: lchang)

References

Details

(Whiteboard: [FT:Stream3])

Attachments

(1 file)

46 bytes, text/x-github-pull-request
johnhu
: review+
GaryChen
: review+
Details | Review
The App List is responsible for rendering app icons to let users can launch a specific app or choose an app as a widget through Widget Editor.
Assignee: nobody → lchang
Depends on: 1009379
Attached file Pull Request 19264
Dear all,

Could you please help to review this patch? Thanks.
Attachment #8422904 - Flags: review?(tzhuang)
Attachment #8422904 - Flags: review?(johu)
Attachment #8422904 - Flags: review?(gchen)
Comment on attachment 8422904 [details] [review]
Pull Request 19264

Thanks. Please find some nits at PR and we forget to put style/images/Default.png image at applications.
Attachment #8422904 - Flags: review?(johu) → review+
Comment on attachment 8422904 [details] [review]
Pull Request 19264

Overall looks good, please address John Hu's comment.
r=garychen, thanks.
Attachment #8422904 - Flags: review?(gchen) → review+
Comment on attachment 8422904 [details] [review]
Pull Request 19264

Clear review flag since there are already two r+.
Attachment #8422904 - Flags: review?(tzhuang)
merged in gaia master branch:
https://github.com/mozilla-b2g/gaia/commit/f7ccbcaf6afe7d632d4bb797ebf53edd663162e1

John, Gary, Thanks!
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Whiteboard: [FT:Stream3]
You need to log in before you can comment on or make changes to this bug.