1002698 - Implement Australis Style Edit Bookmark panel

Status: RESOLVED WONTFIX

(Firefox :: Theme, defect)

Description

[Zhenshuo Fang (:fang) - Firefox UX Team]

+++ This bug was initially created as a clone of Bug #978459 +++

Implement the design in bug 978459

Comment 1

[:Gijs (he/him)]

Zhenshuo, it looks like the blue star is different in the new design. Can you provide the assets that need to be used here on all three platforms (and the different windows styles) ?

Comment 2

[Zhenshuo Fang (:fang) - Firefox UX Team]

(In reply to :Gijs Kruitbosch from comment #1)
> Zhenshuo, it looks like the blue star is different in the new design. Can
> you provide the assets that need to be used here on all three platforms (and
> the different windows styles) ?

For the toolbar button we can use the assets here. http://people.mozilla.org/~shorlander/drops/australis-toolbar-and-menuPanel-icons/

There's no blue star there so I'll create separate ones. Any requirement on the size of the star or it's the same with what's in the Menu panel?

Comment 3

[:Gijs (he/him)]

(In reply to Zhenshuo Fang (:fang) - Firefox UX Team from comment #2)
> (In reply to :Gijs Kruitbosch from comment #1)
> > Zhenshuo, it looks like the blue star is different in the new design. Can
> > you provide the assets that need to be used here on all three platforms (and
> > the different windows styles) ?
> 
> For the toolbar button we can use the assets here.
> http://people.mozilla.org/~shorlander/drops/australis-toolbar-and-menuPanel-
> icons/
> 
> There's no blue star there so I'll create separate ones. Any requirement on
> the size of the star or it's the same with what's in the Menu panel?

I don't know. I was hoping you or shorlander could tell us. :-)

Comment 4

[u428464]

AFAIK the star design that was implemented in bug 969904 is more recent that Shorlander's mockup.

Comment 5

[:Gijs (he/him)]

(In reply to Guillaume C. [:ge3k0s] from comment #4)
> AFAIK the star design that was implemented in bug 969904 is more recent that
> Shorlander's mockup.

But I'm not looking at the mockup, I'm looking at https://bug978459.bugzilla.mozilla.org/attachment.cgi?id=8413986, because that's the design linked from the design bug.

I'm also assuming we don't want to actually modify the star button itself - just the edit bookmarks panel, because that's what the summary of the bug says.

Trying to fix the confusion here by updating the URL field.

Comment 6

[u428464]

Sorry I wasn't clear. I think that the star image in the new design (the one by Zfang) is directly taken from Shorlander's mockup. What I was pointing up is that the image implemented by Shorlander in bug 969904 is AFAIK more recent than the original mockup and thus also than the star image in Zfang's mockup.

Comment 7

[u428464]

Side note it would be nice to have the separator between the star/title and the rest of the panel as seen on Shorlander's mockup.

Comment 8

[Zhenshuo Fang (:fang) - Firefox UX Team]

Yes I'm using the same star as in shorlander's mockups, the star is the same one in OSX & Windows.
Shorlander, do you already have the asset for different platforms?

Comment 9

[Zhenshuo Fang (:fang) - Firefox UX Team]

Attachment: bookmarks-noglow.png

I found the original file of the star and hide the glow, use this one for now.

Comment 10

[:Gijs (he/him)]

Some questions:

- can someone provide a hidpi version of the icon?
- should it say "page bookmarked!" even when editing a pre-existing bookmark rather than one you just made?
- the 'remove bookmark' option is now much bigger than the 'done' option; is that intentional? It seems odd.
- can you specify how the padding of the remove bookmark item should work? It currently has more left than right padding, and the right padding doesn't match the left padding of the 'done' item either, so I'm just confused. :-)
- the right corners look very nice on Windows 8 - are we meant to use them as-is on other platforms (earlier Windows, OS X, Linux) as well?
- there is no visible 'cancel' option anymore. Considering the iterations we went through with customize mode, are we sure about that?

Comment 11

[Stephen Horlander [:shorlander]]

(In reply to Zhenshuo Fang (:fang) - Firefox UX Team from comment #8)
> Yes I'm using the same star as in shorlander's mockups, the star is the same
> one in OSX & Windows.
> Shorlander, do you already have the asset for different platforms?

Not sure i understand the question. We currently have:
https://mxr.mozilla.org/mozilla-central/source/browser/themes/osx/places/starred48.png
https://mxr.mozilla.org/mozilla-central/source/browser/themes/windows/places/starred48-aero.png
https://mxr.mozilla.org/mozilla-central/source/browser/themes/windows/places/starred48.png
https://mxr.mozilla.org/mozilla-central/source/browser/themes/linux/places/starred48.png

What do we need instead?

Comment 12

[Marco Mucci [:MarcoM]]

Removed from Iteration 33.1.

Comment 13

[Marco Mucci [:MarcoM]]

Removed from Iteration 33.3

Comment 14

[:Gijs (he/him)]

We didn't even get to this for photon, so marking wontfix. We might still fix the photon stuff, but not this one.