1003080 - [VR][Messaging] Grey Stroke that circles the contact's photo looks pixelated.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::SMS, defect)

Description

[Loli (:lolimartinezcr)]

Attachment: 2014-04-29-12-34-14.png

Tested
2.0
Hamachi
Gecko: 177f146
Gaia: 4788795

Prerequisites:
Messages sent to contact in phone.

STR
Tap messages.

Actual result:
Contact's photo with pixels in border. (See attached image)
 
Expected result:
Contact's photo without pixels in border. 
It has been seen with Vicky UX

Comment 1

[Julien Wajsberg [:julienw] (PTO -> Aug 14)]

If we need to remove the circle, I think this would solve bug 1003060 as well.

Comment 2

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

triage: obvious UI flaw for VR

Comment 3

[Noemí Freire (:noemi)]

Same scenario as the one raised in Bug 1003060 so marking as duplicate of it. Thanks!

Comment 4

[Julien Wajsberg [:julienw] (PTO -> Aug 14)]

Vicky, I'd like to make sure of what this bug was.

Especially, do we want the circle around the contact picture (only when there is a picture obviously)?

Thanks

Comment 5

[Victoria Gerchinhoren [:vicky]]

(In reply to Julien Wajsberg [:julienw] from comment #4)
> Vicky, I'd like to make sure of what this bug was.
> 
> Especially, do we want the circle around the contact picture (only when
> there is a picture obviously)?
> 
> Thanks

We do not sant the circles when there's no pictures, of course, if there's no photo associated to a contact, we have a blank space as we did before.

On the other hand, the stroke that outlines the picture, looks pixelated, it is doing a odd effect, and this is what this bug is for.

Thanks

Comment 6

[Noemí Freire (:noemi)]

Per comment 5 reopening this bug since bug 1003060 doesn't solve the pixelated effect raised here. Sorry for the previous misunderstanding.

Comment 7

[Joan Leon [:joan]]

Attachment: Change CSS property, border to box-shadow

Comment 8

[Joan Leon [:joan]]

Attachment: Patch in GitHub

Comment 9

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

Comment on attachment 8425522 [details] [review]
Patch in GitHub

Awesome, thanks Joan!

Comment 10

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

Merged: e5c7a881d61068611edd98d717fe1d627f3685f8

Comment 11

[Noemí Freire (:noemi)]

Already landed in master so clearing 2.0? flag

Comment 12

[Loli (:lolimartinezcr)]

Tested and working
Hamachi
2.0
Gecko-b2cdbab
Gaia-7c55cc2

Comment 13

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

Attachment: after patch

Comment 14

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

Revert: beccde2946db1b157185f33a18e29dd751e39b1d

Backing this out, as you can see in attachment 8426271 [details], it was producing an undesired effect in Contacts app, where both box-shadow and border were applied at the same time.

Comment 15

[Julien Wajsberg [:julienw] (PTO -> Aug 14)]

Also, I wonder if can't have a gecko fix for this instead of working around the issue.

Arnau, Joan, can one of you do a simpler testcase for this issue? (like a plain html page reproducing the issue, for example using a data-url PNG background image to make it self-contained).

Comment 16

[Joan Leon [:joan]]

Yes, I make a plain html page reproducing the issue

Comment 17

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

Clearing ni as Joan is on it :)

Comment 18

[Joan Leon [:joan]]

Attachment: Grey Stroke circles Messages Contact List

Comment 19

[Joan Leon [:joan]]

Attachment: Grey Stroke circles in Call Log

Comment 20

[Joan Leon [:joan]]

Attachment: Grey Stroke circles Contacts after fix regression

Comment 21

[Joan Leon [:joan]]

Attachment: Patch in GitHub

Comment 22

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8426881 [details] [review]
Patch in GitHub

Unfortunately the box-shadow is applied to elements that don't have image as  well, so we have lots of empty circles! ;)

Comment 23

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8426881 [details] [review]
Patch in GitHub

Almost!

Sorry, testing the importers (that also have contact list, but unfortunately not sharing the same), this still happens.

To reproduce just import from gmail and you'll see the effect.

Thanks, we are getting closer!

Comment 24

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8426881 [details] [review]
Patch in GitHub

\o/ yeah!

Good work, thanks Joan!

Comment 25

[Francisco Jordano [:arcturus] [:francisco]]

Leaving a needinfo for myself since I need to merge this once travis is green.

Comment 26

[Francisco Jordano [:arcturus] [:francisco]]

Finally landed:

https://github.com/nucliweb/gaia/commit/731f30946862c0557d3f9e986fbfa22eb7d3ddf5

\o/

Comment 27

[Julien Wajsberg [:julienw] (PTO -> Aug 14)]

Joan, I still would like a plain HTML page reproducing the issue so that we can see if there is a Gecko issue we could fix.

Comment 28

[Joan Leon [:joan]]

Perfect ;)

Comment 29

[Julien Wajsberg [:julienw] (PTO -> Aug 14)]

Reproducible issues in:
https://github.com/nucliweb/FxOS-Stroke-Circle
http://nucliweb.github.io/FxOS-Stroke-Circle/

(I don't have time to handle this now, that's why I'm tracking them here so that I can go back at it later).

Comment 30

[Loli (:lolimartinezcr)]

Tested and working
Hamachi
2.0
Gecko 785d39a
Gaia 7f258db