1003060 - [VR][Messaging] Empty circle to the right in messages without recipient

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::SMS, defect)

Description

[Loli (:lolimartinezcr)]

Attachment: 2014-04-29-11-32-36.png

Tested
2.0
Hamachi
Gecko
Gaia

Reproducible: 100%

STR
1) Tap messages aplication.
2) Tap "new message" button.
3) Write body messsage.
4) Tap left arrow.
5) Tap "Save as Draft" button.

Actual result
You can see message in list with title "(No recipient)" and empty circle. (See attached image)

Expected result:
You can see message in list with title "(No recipient)" and *NOT* empty circle. (See attached image)

Comment 1

[Loli (:lolimartinezcr)]

Blocks: 963019

Comment 2

[Julien Wajsberg [:julienw]]

I thought we had already a bug for this but maybe we only discussed it without opening it. IIRC we need to add a class for lines without a picture.

Comment 3

[Julien Wajsberg [:julienw]]

bug 1003080 should fix this issue.

Comment 4

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

triage: obvious UI flaw for VR

Comment 6

[Joan Leon [:joan]]

Attachment: Patch in GitHub

Comment 7

[Julien Wajsberg [:julienw]]

Seems fine but I want to first make sure of whether bug 1003080 was really the same.

Comment 8

[Julien Wajsberg [:julienw]]

Comment on attachment 8424996 [details] [review]
Patch in GitHub

This does not depend on what bug 1003080 is about so r=me.

Thanks !

Comment 9

[Julien Wajsberg [:julienw]]

Comment on attachment 8424996 [details] [review]
Patch in GitHub

please add r=julien in your commit and then add checkin-needed in the keyword section on the bug.

Thanks !

Comment 10

[Ryan VanderMeulen [:RyanVM]]

Master: https://github.com/mozilla-b2g/gaia/commit/385f097419300d1e5968ad1df60a1b3931b77dcf

Comment 11

[Loli (:lolimartinezcr)]

Tested and working
Hamachi 
2.0
Gecko-564e4e1
Gaia-a436da1