1005657 - Improve nsMathMLChar::StretchEnumContext::TryParts for the generic Unicode table

Status: RESOLVED FIXED

(Core :: MathML, defect)

Comment 1

[Frédéric Wang (:fredw)]

Attachment: Patch

For some reason, the bug of stretchy unicode construction with missing glyphs appeared in bug 1000879. Let's try to fix that.

Comment 2

[Frédéric Wang (:fredw)]

https://tbpl.mozilla.org/?tree=Try&rev=47543575ca3e

Comment 3

[Frédéric Wang (:fredw)]

Comment on attachment 8417054 [details] [diff] [review]
Patch

Apparently, mathml/mfenced-10.html should be marked again fails on Windows XP. Bug 670592 does not happen when Cambria Math is installed, though.

Comment 4

[Bill Gianopoulos [:WG9s]]

(In reply to Frédéric Wang (:fredw) |away 27/04 to 06/05 from comment #3)
> Comment on attachment 8417054 [details] [diff] [review]
> Patch
> 
> Apparently, mathml/mfenced-10.html should be marked again fails on Windows
> XP. Bug 670592 does not happen when Cambria Math is installed, though.


Is this at all relevant since Windows XP is no longer supported by the OS vendor???

Comment 5

[Frédéric Wang (:fredw)]

Attachment: Patch

Comment 6

[Frédéric Wang (:fredw)]

(In reply to Bill Gianopoulos [:WG9s] from comment #4)
> Is this at all relevant since Windows XP is no longer supported by the OS
> vendor???

Mozilla still supports Windows XP, I think. Anyway, this bug has been known for a long time, so it's worth fixing it (even if it only happens on platform without math fonts).

Comment 7

[Karl Tomlinson (:karlt)]

Comment on attachment 8417337 [details] [diff] [review]
Patch

>+        unicodeFont = glyphRuns[0].mFont.get();
>+      } else if (unicodeFont != glyphRuns[0].mFont.get()) {

I would have expected the get() calls here to be unnecessary.
Can you try removing each of them, please?

>-== mfenced-10.html mfenced-10-ref.html
>+fails-if(/^Windows\x20NT\x205\.1/.test(http.oscpu)) == mfenced-10.html mfenced-10-ref.html # Windows versions without Cambria Math

Can you reference bug 670592 in the comment, please?

Comment 8

[Frédéric Wang (:fredw)]

Attachment: Patch

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6363775a4cd9

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/6363775a4cd9