Closed Bug 1005657 Opened 6 years ago Closed 6 years ago

Improve nsMathMLChar::StretchEnumContext::TryParts for the generic Unicode table

Categories

(Core :: MathML, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla32

People

(Reporter: fredw, Assigned: fredw)

Details

Attachments

(1 file, 2 obsolete files)

No description provided.
Attached patch Patch (obsolete) — Splinter Review
For some reason, the bug of stretchy unicode construction with missing glyphs appeared in bug 1000879. Let's try to fix that.
Assignee: nobody → fred.wang
Status: NEW → ASSIGNED
Comment on attachment 8417054 [details] [diff] [review]
Patch

Apparently, mathml/mfenced-10.html should be marked again fails on Windows XP. Bug 670592 does not happen when Cambria Math is installed, though.
Attachment #8417054 - Flags: review?(karlt)
(In reply to Frédéric Wang (:fredw) |away 27/04 to 06/05 from comment #3)
> Comment on attachment 8417054 [details] [diff] [review]
> Patch
> 
> Apparently, mathml/mfenced-10.html should be marked again fails on Windows
> XP. Bug 670592 does not happen when Cambria Math is installed, though.


Is this at all relevant since Windows XP is no longer supported by the OS vendor???
Attached patch Patch (obsolete) — Splinter Review
Attachment #8417054 - Attachment is obsolete: true
Attachment #8417054 - Flags: review?(karlt)
Attachment #8417337 - Flags: review?(karlt)
(In reply to Bill Gianopoulos [:WG9s] from comment #4)
> Is this at all relevant since Windows XP is no longer supported by the OS
> vendor???

Mozilla still supports Windows XP, I think. Anyway, this bug has been known for a long time, so it's worth fixing it (even if it only happens on platform without math fonts).
Comment on attachment 8417337 [details] [diff] [review]
Patch

>+        unicodeFont = glyphRuns[0].mFont.get();
>+      } else if (unicodeFont != glyphRuns[0].mFont.get()) {

I would have expected the get() calls here to be unnecessary.
Can you try removing each of them, please?

>-== mfenced-10.html mfenced-10-ref.html
>+fails-if(/^Windows\x20NT\x205\.1/.test(http.oscpu)) == mfenced-10.html mfenced-10-ref.html # Windows versions without Cambria Math

Can you reference bug 670592 in the comment, please?
Attachment #8417337 - Flags: review?(karlt) → review+
Attached patch PatchSplinter Review
Attachment #8417337 - Attachment is obsolete: true
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/6363775a4cd9
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
You need to log in before you can comment on or make changes to this bug.