1006299 - Rename options.enablePersistentLogging.tooltip to reflect new string content

Status: RESOLVED FIXED

(DevTools :: Netmonitor, defect)

Description

[Francesco Lodolo [:flod]]

Changeset
https://hg.mozilla.org/mozilla-central/rev/aaeff6d3bb3b

options.enablePersistentLogging.tooltip changed without a new ID
https://developer.mozilla.org/en-US/docs/Making_String_Changes

Please fix this on mozilla-central, nothing we can do for the change slipped in mozilla-aurora.

Comment 1

[Francesco Lodolo [:flod]]

Attachment: bug1006299.patch

Rename options.enablePersistentLogging.label to options.enablePersistentLogs.label

Comment 2

[Francesco Lodolo [:flod]]

Thanks Victor, setting keyword for check-in.

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/850ddb0b7d38

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/850ddb0b7d38

Comment 5

[Girish Sharma [:Optimizer]]

Joel, I don't think so this bug can cause those regressions in any way. This is (almost) just a string change in some feature that is not even in use while such suites run.

Comment 6

[Francesco Lodolo [:flod]]

(In reply to Girish Sharma [:Optimizer] from comment #5)
> Joel, I don't think so this bug can cause those regressions in any way. This
> is (almost) just a string change in some feature that is not even in use
> while such suites run.

Yes, this definitely can't impact performance, it's just renaming a string ID, not introducing anything new.