1006320 - (webbt-test-manager) Write marionette tests for BluetoothManager

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Bluetooth, defect)

Description

[Ben Tian (inactive)]

Write marionette tests for BluetoothManager API.

Comment 1

[Jamin Liu [:jaliu][:Jamin]]

Attachment: [dev] Add a marionette test for verifying the functionality BluetoothManager in development stage for device. (v0)

Comment 2

[Jamin Liu [:jaliu][:Jamin]]

Attachment: [dev] Add a marionette test for verifying the functionality BluetoothManager in development stage for device. (v0)

Comment 3

[Jamin Liu [:jaliu][:Jamin]]

The 'bluetooth2' API should pass the marionette test in #attachment 8441934 [details] [diff] [review] when Bug 1027552 land.

Please switch BT API to 'bluetooth2' by applying API configuration patch #attachment 8426731 [details] [diff] [review] which was attached in Bug 1005848 before you run this test.

Comment 4

[Jamin Liu [:jaliu][:Jamin]]

The #attachment 8441934 [details] [diff] [review] is based on #attachment 8442702 [details] [diff] [review] which is attached at Bug 1006317.

Comment 5

[Jamin Liu [:jaliu][:Jamin]]

Attachment: (part 1) Remove useless bluetooth API tests from bluetooth2 folder.

Comment 6

[Jamin Liu [:jaliu][:Jamin]]

Attachment: (part 2) Add a marionette test for verifying the functionality BluetoothManager based on bluetooth API v2.

Comment 7

[Ben Tian (inactive)]

Comment on attachment 8447896 [details] [diff] [review]
(part 1) Remove useless bluetooth API tests from bluetooth2 folder.

Review of attachment 8447896 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with comment addressed.

::: dom/bluetooth2/tests/marionette/head.js
@@ +32,5 @@
>  const BDADDR_ANY   = "00:00:00:00:00:00";
>  const BDADDR_ALL   = "ff:ff:ff:ff:ff:ff";
>  const BDADDR_LOCAL = "ff:ff:ff:00:00:00";
>  
>  // A user friendly name for remote BT device.

nit: 'An' user friendly name

@@ +47,5 @@
> + * Push required permissions and test if |navigator.mozBluetooth| exists.
> + * Resolve if it does, reject otherwise.
> + *
> + * Fulfill params:
> + *   bluetoothManager -- an reference to navigator.mozBluetooth.

nit: 'a' reference

@@ +51,5 @@
> + *   bluetoothManager -- an reference to navigator.mozBluetooth.
> + * Reject params: (none)
> + *
> + * @param aPermissions
> + *        Additional permissions to push before any test cases.  Could be either

nit: remove extra space before 'Could'

@@ +303,5 @@
>    return deferred.promise;
>  }
>  
>  /**
> + * Get the boolean value which indicates defaultAdapter of bluetooth is enabled.

nit: indicates 'whether' defaultAdapter ...

@@ +415,5 @@
>        cleanUp();
>      });
>  }
>  
>  function startBluetoothTest(aReenable, aTestCaseMain) {

Please add comment to explain this function.

Comment 8

[Ben Tian (inactive)]

Comment on attachment 8447897 [details] [diff] [review]
(part 2) Add a marionette test for verifying the functionality BluetoothManager based on bluetooth API v2.

Review of attachment 8447897 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with nits addressed. Thanks.

::: dom/bluetooth2/tests/marionette/test_dom_BluetoothManager_API2.js
@@ +7,5 @@
> +//   To verify the basic functionality of BluetoothManager.
> +//
> +// Test Coverage:
> +//   - BluetoothManager.defaultAdapter
> +//   - BluetoothManagergetAdapters()

nit: BluetoothManager'.'getAdapters()

@@ +18,5 @@
> +
> +MARIONETTE_TIMEOUT = 60000;
> +MARIONETTE_HEAD_JS = 'head.js';
> +
> +// TODO: Listen to 'onattributechanged' when bluetooth2 API support it.

Is this TODO comment still required? Remove if it's not required anymore.

Comment 9

[Jamin Liu [:jaliu][:Jamin]]

Attachment: (part 1) Remove useless bluetooth API tests from bluetooth2 folder. r=btian

Comment 10

[Jamin Liu [:jaliu][:Jamin]]

Attachment: (part 2) Add a marionette test for verifying the functionality BluetoothManager based on bluetooth API v2. r=btian

Comment 11

[Jamin Liu [:jaliu][:Jamin]]

Thank you for your comments.
I've uploaded a new patch based on your comments.

(In reply to Ben Tian [:btian] from comment #8)
> > +MARIONETTE_TIMEOUT = 60000;
> > +MARIONETTE_HEAD_JS = 'head.js';
> > +
> > +// TODO: Listen to 'onattributechanged' when bluetooth2 API support it.
> 
> Is this TODO comment still required? Remove if it's not required anymore.
Thank you for reminding me.
I modified this comment and add a description for it.

Comment 12

[Ben Tian (inactive)]

https://hg.mozilla.org/integration/b2g-inbound/rev/daacb7f83ded
https://hg.mozilla.org/integration/b2g-inbound/rev/68efa2e3d9bf

Comment 13

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/daacb7f83ded
https://hg.mozilla.org/mozilla-central/rev/68efa2e3d9bf